Add support for the Strimzi Metrics Reporter #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mimaison
reviewed
Dec 17, 2024
fvaleri
force-pushed
the
bridge-metrics-rep
branch
from
a211d27 to
9385323
Compare
scholzj
reviewed
Dec 17, 2024
There was a problem hiding this comment.
I wonder if this should go through a dedicated proposal first. The original proposal - https://github.com/strimzi/proposals/blob/main/064-prometheus-metrics-reporter.md - sadly didn't cover the bridge in sufficient depth and there will be some backward compatibility impact here or in the operators repo that needs to be carefully considered. A proposal would be the right place to discuss it and decide on the best approach.
I agree. Probably the backwards incompatible changes are mostly on the operator side, where we have to introduce |
fvaleri
force-pushed
the
bridge-metrics-rep
branch
from
4a47979 to
4d87ff9
Compare
ppatierno
reviewed
Dec 20, 2024
fvaleri
force-pushed
the
bridge-metrics-rep
branch
from
4d87ff9 to
8b9e345
Compare
This patch adds support for the Strimzi Metrics Reporter. Setting `bridge.metrics=jmxPrometheusExporter` enables the JMX Prometheus Exporter (equivalent to KAFKA_BRIDGE_METRICS_ENABLED=true). Setting `bridge.metrics=strimziMetricsReporter` enables the new Strimzi Metrics Reporter as Kafka plugin. When selecting the `strimziMetricsReporter`, you also need to add the plugin configuration as in the following example: ```sh bridge.metrics=strimziMetricsReporter kafka.metric.reporters=io.strimzi.kafka.metrics.KafkaPrometheusMetricsReporter kafka.prometheus.metrics.reporter.listener.enable=false kafka.prometheus.metrics.reporter.allowlist=.* ``` Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
Implementation of "Integrate Bridge with Metrics Reporter" proposal. Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
fvaleri
force-pushed
the
bridge-metrics-rep
branch
from
8b9e345 to
d0eedcd
Compare
Signed-off-by: Federico Valeri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for the Strimzi Metrics Reporter.
Setting
bridge.metrics=jmxPrometheusExporterenables the JMX Prometheus Exporter (equivalent to KAFKA_BRIDGE_METRICS_ENABLED=true). Settingbridge.metrics=strimziMetricsReporterenables the new Strimzi Metrics Reporter as Kafka plugin.When selecting the
strimziMetricsReporter, you also need to add the plugin configuration as in the following example:bridge.metrics=strimziMetricsReporter kafka.metric.reporters=io.strimzi.kafka.metrics.KafkaPrometheusMetricsReporter kafka.prometheus.metrics.reporter.listener.enable=false kafka.prometheus.metrics.reporter.allowlist=.*See strimzi/proposals#143 for more details.