Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Touch functionality not working as expected #4096

Open
4 tasks done
therealharshit opened this issue Dec 4, 2024 · 7 comments · May be fixed by #4213
Open
4 tasks done

Touch functionality not working as expected #4096

therealharshit opened this issue Dec 4, 2024 · 7 comments · May be fixed by #4213
Labels
Issue-Bug

Comments

@therealharshit
Copy link
Contributor

therealharshit commented Dec 4, 2024 •
edited
Loading

Description

When we try to scroll the block container using two finger it is moving in opposite direction and context menu are not opening.

Expected Behavior

Block container should move in the direction we are scrolling, and context menu should open.

Vedio

MB-touch.1.mp4

How to Reproduce

  1. Open Musicblock on any touch device.
  2. Try to scroll the block container using two finger.

(refer to vedio)

Console log Errors:

N/A

Environment:

  • Operating System: Android
  • Browser (if applicable): Chrome
  • Version of Software/Project: Master branch

Checklist

  • I have read and followed the project's code of conduct.
  • I have searched for similar issues before creating this one.
  • I have provided all the necessary information to understand and reproduce the issue.
  • I am willing to contribute to the resolution of this issue.

Thank you for contributing to our project! We appreciate your help in improving it.

📚 See contributing instructions.

🙋🏾🙋🏼 Questions: Community Matrix Server.
@therealharshit
Copy link
Contributor Author

@walterbender I was testing it from master branch on my tablet by exposing my localhost,

  1. The block container is scrolling properly using one finger (i think it was fixed in 3ac55f7), now do we really need two finger touch?
  2. I think we should treat long press as right click to open context menu, what do you think?

@shrutibhardwaj22
Copy link

I would like to work on this issue. Can you please assign it to me?

@walterbender
Copy link
Member

@shrutibhardwaj22 we don't assign issues but feel free to contribute

@therealharshit
Copy link
Contributor Author

I would like to work on this issue. Can you please assign it to me?

@shrutibhardwaj22 we don't assign issues, and some more testing and review is required before we start working on it.

@walterbender
Copy link
Member

@therealharshit 's suggestion is a good one. Maybe you can help document the current behavior so we can collectively make a plan as to what we want to prioritize.

@jivansh77
Copy link
Contributor

@walterbender I am working on this issue, should not scrolling only happen vertically, even when using 2 fingers?

@walterbender
Copy link
Member

Vertical vs Vertical and Horizontal is determined by the state of the Enable-Horizontal-Scrolling flag

jivansh77 added a commit to jivansh77/musicblocks that referenced this issue Dec 30, 2024
@jivansh77
Fixes sugarlabs#4096 touch functionality
70833b5
@jivansh77 jivansh77 linked a pull request Dec 30, 2024 that will close this issue
Open
jivansh77 added a commit to jivansh77/musicblocks that referenced this issue Jan 5, 2025
@jivansh77
Fixes sugarlabs#4096 touch functionality
466ce77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes Touch Functionality jivansh77/musicblocks
4 participants
@walterbender @jivansh77 @shrutibhardwaj22 @therealharshit