Skip to content
This repository has been archived by the owner on Aug 3, 2024. It is now read-only.

Renderer should not be accessible as a field on Compositor #295

Open
Timidger opened this issue Apr 2, 2019 · 0 comments
Open

Renderer should not be accessible as a field on Compositor #295

Timidger opened this issue Apr 2, 2019 · 0 comments
Labels
Breaking Breaking changes Unsound

Comments

@Timidger
Copy link
Member

Timidger commented Apr 2, 2019

With the addition of DMA buffers (and probably output damage later) there needs to be pointers from the renderer living elsewhere. Since the renderer is optional, it is publically acessible as an Option<GenericRenderer> so at any time the user could destroy it by storing a None in there. Not good if we don't want dangling pointers.

To get around this we will need to add getters so that it's impossible to set the renderer after creation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Breaking Breaking changes Unsound
Development

Successfully merging a pull request may close this issue.

1 participant