Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java 11 compatibility #80

Open
wetneb opened this issue Feb 5, 2022 · 0 comments
Open

Java 11 compatibility #80

wetneb opened this issue Feb 5, 2022 · 0 comments

Comments

@wetneb
Copy link
Member

wetneb commented Feb 5, 2022

Running mvn test with OpenJDK 11 I get a lot of compilation failures which seem to be due to the change of coordinates of the javax classes (I think this is related to the JDK version).

[ERROR] /home/antonin/osr-common/tooling/sweble-wikitext/sweble-wikitext-components-parent/swc-engine/src/main/java/org/sweble/wikitext/engine/ParserFunctionBase.java:[23,33] package javax.xml.bind.annotation does not exist
[ERROR] /home/antonin/osr-common/tooling/sweble-wikitext/sweble-wikitext-components-parent/swc-engine/src/main/java/org/sweble/wikitext/engine/ParserFunctionBase.java:[24,33] package javax.xml.bind.annotation does not exist
[ERROR] /home/antonin/osr-common/tooling/sweble-wikitext/sweble-wikitext-components-parent/swc-engine/src/main/java/org/sweble/wikitext/engine/ParserFunctionBase.java:[25,42] package javax.xml.bind.annotation.adapters does not exist
[ERROR] /home/antonin/osr-common/tooling/sweble-wikitext/sweble-wikitext-components-parent/swc-engine/src/main/java/org/sweble/wikitext/engine/ParserFunctionBase.java:[26,42] package javax.xml.bind.annotation.adapters does not exist
[ERROR] /home/antonin/osr-common/tooling/sweble-wikitext/sweble-wikitext-components-parent/swc-engine/src/main/java/org/sweble/wikitext/engine/ParserFunctionBase.java:[34,2] cannot find symbol
[ERROR]   symbol: class XmlTransient
[ERROR] /home/antonin/osr-common/tooling/sweble-wikitext/sweble-wikitext-components-parent/swc-engine/src/main/java/org/sweble/wikitext/engine/ParserFunctionBase.java:[35,2] cannot find symbol
[ERROR]   symbol: class XmlJavaTypeAdapter
wetneb added a commit that referenced this issue Feb 5, 2022
@wetneb
Add explicit dependency to jaxb-api, for #80
ad46e9d
wetneb added a commit that referenced this issue Feb 5, 2022
@wetneb
Add explicit dependency to jaxb-api, for #80
5e7c236
wetneb added a commit that referenced this issue Feb 5, 2022
@wetneb
Add Java 11 to the CI, for #80
01c6cb9
wetneb added a commit that referenced this issue May 28, 2022
@jberkel @wetneb
Java 11 changes (#84)
5c5eccd 
* Add explicit dependency to jaxb-api, for #80

* Add Java 11 to the CI, for #80

* Resolve localization differences across Java versions in tests

* Add JAXB bindings for submodules

* All tests passing

* Run all jobs to completion

https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#handling-failures

* Handle Java 8 locale difference

* Use Java 8 compatible plugin

Co-authored-by: Antonin Delpeuch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wetneb