Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate use of git-commit-id-plugin and make compatible with shallow clones or archives #82

Open
wetneb opened this issue Feb 5, 2022 · 1 comment

Comments

@wetneb
Copy link
Member

wetneb commented Feb 5, 2022

The use of the git-commit-id-plugin requires that Maven builds are triggered from a full clone of the repository. This makes the CI slightly more wasteful (since it has to fetch the entire repository instead of the commit being built). It also indicates that if someones downloads an archive of the source code from GitHub and tries to build it locally, it will probably also fail (because of the lack of a .git subdirectory).
The git-commit-id-plugin can be configured to be skipped if the information is not available, which is probably the right thing to do here.

@wetneb
Copy link
Member Author

wetneb commented Feb 5, 2022

When this is done, the CI configuration should be changed to make all the clones shallow (remove the fetch-depth lines).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant