Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing delegate doc #1869

Closed
nitriques opened this issue Nov 14, 2013 · 10 comments
Closed

Missing delegate doc #1869

nitriques opened this issue Nov 14, 2013 · 10 comments
Assignees

Comments

@nitriques
Copy link
Member

This delegate, 'CustomActions', is not in the docs and I can't tell why.

https://github.com/symphonycms/symphony-2/blob/master/symphony/content/content.publish.php#L513

I also do not know why it's called only in the __actionIndex, why not __actionEdit and __actionNew ?

@designermonkey
Copy link
Member

Custom Actions are intrinsically linked to the With Selected menu, so they wouldn't be on the new and edit screens.

Why they are not in the docs is weird though.

@nitriques
Copy link
Member Author

Yeah. I looked at the format of the other delegates and could not spot the problem.

I would suggest to add another delegate that would be available to all views in the publish section.

@designermonkey
Copy link
Member

There are already delegates for administration pages, and you can find the exact page by using the $context array

@nitriques
Copy link
Member Author

Yeah but the thing I want is to have a single delegate for index, new and edit.

@brendo
Copy link
Member

brendo commented Nov 26, 2013

Interestingly enough, the documentation configuration ignores all files in /content, so none of the delegates in those files will be parsed.

Removing this restriction should enable us to parse out the delegates, but we may need to a do a little cleanup of the 'Unknown' classes that it will produce given that we don't document the /content.

@brendo
Copy link
Member

brendo commented Nov 26, 2013

Mmm, I take that back, even though it's omitted they still exist in the raw XML file...

@brendo
Copy link
Member

brendo commented Nov 26, 2013

Actually I thinks it's because the Custom Actions delegate is in two spots

@nitriques
Copy link
Member Author

Hummm... weird.

@nilshoerrmann
Copy link
Contributor

Is this something that can (and will) be solved?

@nilshoerrmann
Copy link
Contributor

This has been moved to symphonycms/symphony-phpdoc#1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants