Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed flag name in help (--project to --projects) #1419

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

i582
Copy link
Contributor

@i582 i582 commented Jan 20, 2025

Issue

Closes #1273.

Checklist

  • I have updated CHANGELOG.md
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@i582 i582 added this to the v1.6.0 milestone Jan 20, 2025
@i582 i582 requested a review from a team as a code owner January 20, 2025 17:32
@i582 i582 changed the title fix: fixed flag name in help Fixed flag name in help (--project to --projects) Jan 20, 2025
Copy link
Member

@novusnota novusnota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold on, the -p, --project flag is correct since it denotes a name of the project to build and it can be specified multiple times to selectively build multiple projects.

The issue wasn't with the help text, but with the actual CLI flag — it's --projects now, but should be just like in the help, i.e. --project

@i582
Copy link
Contributor Author

i582 commented Jan 20, 2025

Hold on, the -p, --project flag is correct since it denotes a name of the project to build and it can be specified multiple times to selectively build multiple projects.

The issue wasn't with the help text, but with the actual CLI flag — it's --projects now, but should be just like in the help, i.e. --project

What about current users who use the current --projects flag? If we change it to --project, we break all code that depends on the --projects flag

@anton-trunov
Copy link
Member

@novusnota since we allow specifying multiple projects, it's only logical to call it --projects (plural)

@anton-trunov anton-trunov merged commit f831d9d into main Jan 20, 2025
16 of 17 checks passed
@anton-trunov anton-trunov deleted the pmakhnev/fix-flag-name-in-help branch January 20, 2025 18:53
@anton-trunov anton-trunov self-assigned this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--project flag doesn't exist
3 participants