Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set proper Content-type #13

Open
better0fdead opened this issue Jul 12, 2024 · 0 comments
Open

Set proper Content-type #13

better0fdead opened this issue Jul 12, 2024 · 0 comments
Labels
1sp bug Something isn't working good first issue Good for newcomers teamE

Comments

@better0fdead
Copy link
Contributor

For now, if i export metrics with json i get that output:

f.terekhin@f-terekhin tt % curl -s -I -X GET http://127.0.0.1:8082/metrics/json
HTTP/1.1 200 Ok
Content-length: 17348
Server: Tarantool http (tarantool v3.2.0-entrypoint-0-g7fd530f)
Content-type: text/plain; charset=utf-8
Connection: keep-alive

Content-type is text/plain; charset=utf-8, not json.
Need to set proper Content-type.
@better0fdead better0fdead added bug Something isn't working teamE labels Jul 12, 2024
@oleg-jukovec oleg-jukovec added 1sp good first issue Good for newcomers labels Jul 12, 2024
vakhov added a commit to vakhov/metrics-export-role that referenced this issue Dec 28, 2024
@vakhov
Fix Content-Type header for metrics endpoints
fa3e31b 
Issue tarantool#13:
- JSON endpoints now return the correct Content-Type: `application/json; charset=utf-8`.

Additionally:
- Added tests to verify the correctness of the Content-Type header.

This fix ensures proper header formatting and alignment with client expectations.
@vakhov vakhov mentioned this issue Dec 28, 2024
Open
vakhov added a commit to vakhov/metrics-export-role that referenced this issue Dec 28, 2024
@vakhov
Fix Content-Type header for metrics endpoints
203ddf5 
Issue tarantool#13:
- JSON endpoints now return the correct Content-Type: `application/json; charset=utf-8`.

Additionally:
- Added tests to verify the correctness of the Content-Type header.

This fix ensures proper header formatting and alignment with client expectations.
vakhov added a commit to vakhov/metrics-export-role that referenced this issue Dec 28, 2024
@vakhov
fix: content-type header for metrics endpoints
f788f0c 
    Issue tarantool#13:
    - JSON endpoints now return the correct Content-Type: `application/json; charset=utf-8`.

    Additionally:
    - Added tests to verify the correctness of the Content-Type header.

    This fix ensures proper header formatting and alignment with client expectations.
vakhov added a commit to vakhov/metrics-export-role that referenced this issue Dec 28, 2024
@vakhov
fix: content-type header for metrics endpoints
814fe8b 
    Issue tarantool#13:
    - JSON endpoints now return the correct Content-Type: `application/json; charset=utf-8`.

    Additionally:
    - Added tests to verify the correctness of the Content-Type header.

    This fix ensures proper header formatting and alignment with client expectations.
vakhov added a commit to vakhov/metrics-export-role that referenced this issue Dec 28, 2024
@vakhov
fix: content-type header for metrics endpoints
f18401a 
    Issue tarantool#13:
    - JSON endpoints now return the correct Content-Type: `application/json; charset=utf-8`.

    Additionally:
    - Added tests to verify the correctness of the Content-Type header.

    This fix ensures proper header formatting and alignment with client expectations.
vakhov added a commit to vakhov/metrics-export-role that referenced this issue Dec 28, 2024
@vakhov
fix: content-type header for metrics endpoints
199cc67 
    Issue tarantool#13:
    - JSON endpoints now return the correct Content-Type: `application/json; charset=utf-8`.

    Additionally:
    - Added tests to verify the correctness of the Content-Type header.

    This fix ensures proper header formatting and alignment with client expectations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1sp bug Something isn't working good first issue Good for newcomers teamE
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oleg-jukovec @better0fdead