From 594d837ef38a5c82501a376c9744b4f9354fd204 Mon Sep 17 00:00:00 2001
From: Tarek <tareknaser360@gmail.com>
Date: Thu, 14 Mar 2024 14:45:49 +0200
Subject: [PATCH] fix(ci): disable benchmarks for all crates in the workspace

The bench feature has been disabled for all crates within the workspace to resolve an issue encountered during CI testing.

The reason is that by default, Cargo implicitly adds a libtest benchmark harness to any crate when benchmarking, to handle any #[bench] functions, even if we have none. This ruins our Benchmarking CI with the error (Unrecognized option: save-baseline) in the logs.

For more details: https://bheisler.github.io/criterion.rs/book/faq.html#cargo-bench-gives-unrecognized-option-errors-for-valid-command-line-options

Signed-off-by: Tarek <tareknaser360@gmail.com>
---
 data-error/Cargo.toml         | 5 +++++
 data-json/Cargo.toml          | 4 ++++
 data-link/Cargo.toml          | 1 +
 data-pdf/Cargo.toml           | 1 +
 fs-atomic-light/Cargo.toml    | 1 +
 fs-atomic-versions/Cargo.toml | 1 +
 fs-metadata/Cargo.toml        | 4 ++++
 fs-properties/Cargo.toml      | 4 ++++
 fs-storage/Cargo.toml         | 4 ++++
 9 files changed, 25 insertions(+)

diff --git a/data-error/Cargo.toml b/data-error/Cargo.toml
index b30cb2a6..63ac295d 100644
--- a/data-error/Cargo.toml
+++ b/data-error/Cargo.toml
@@ -3,6 +3,11 @@ name = "data-error"
 version = "0.1.0"
 edition = "2021"
 
+[lib]
+name = "data_error"
+crate-type = ["rlib"]
+bench = false
+
 [dependencies]
 thiserror = "1"
 reqwest = "0.11.11"
diff --git a/data-json/Cargo.toml b/data-json/Cargo.toml
index b56702df..0bd7f9aa 100644
--- a/data-json/Cargo.toml
+++ b/data-json/Cargo.toml
@@ -3,6 +3,10 @@ name = "data-json"
 version = "0.1.0"
 edition = "2021"
 
+[lib]
+name = "data_json"
+crate-type = ["rlib"]
+bench = false
 
 [dependencies]
 serde_json = "1.0.82"
diff --git a/data-link/Cargo.toml b/data-link/Cargo.toml
index 3fe9642b..71c3d960 100644
--- a/data-link/Cargo.toml
+++ b/data-link/Cargo.toml
@@ -6,6 +6,7 @@ edition = "2021"
 [lib]
 name = "data_link"
 crate-type = ["rlib"]
+bench = false
 
 [dependencies]
 fs-atomic-light = { path = "../fs-atomic-light" }
diff --git a/data-pdf/Cargo.toml b/data-pdf/Cargo.toml
index 497c8bc3..e6f31cd5 100644
--- a/data-pdf/Cargo.toml
+++ b/data-pdf/Cargo.toml
@@ -6,6 +6,7 @@ edition = "2021"
 [lib]
 name = "data_pdf"
 crate-type = ["rlib"]
+bench = false
 
 [dependencies]
 once_cell = "1.16.0"
diff --git a/fs-atomic-light/Cargo.toml b/fs-atomic-light/Cargo.toml
index abb4a81c..5c15bd54 100644
--- a/fs-atomic-light/Cargo.toml
+++ b/fs-atomic-light/Cargo.toml
@@ -6,6 +6,7 @@ edition = "2021"
 [lib]
 name = "fs_atomic_light"
 crate-type = ["rlib"]
+bench = false
 
 [dependencies]
 data-error = { path = "../data-error" }
diff --git a/fs-atomic-versions/Cargo.toml b/fs-atomic-versions/Cargo.toml
index d3cab8e5..70372063 100644
--- a/fs-atomic-versions/Cargo.toml
+++ b/fs-atomic-versions/Cargo.toml
@@ -6,6 +6,7 @@ edition = "2021"
 [lib]
 name = "fs_atomic_versions"
 crate-type = ["rlib"]
+bench = false
 
 [dependencies]
 data-error = { path = "../data-error" }
diff --git a/fs-metadata/Cargo.toml b/fs-metadata/Cargo.toml
index 184a341f..89a9e03b 100644
--- a/fs-metadata/Cargo.toml
+++ b/fs-metadata/Cargo.toml
@@ -3,6 +3,10 @@ name = "fs-metadata"
 version = "0.1.0"
 edition = "2021"
 
+[lib]
+name = "fs_metadata"
+crate-type = ["rlib"]
+bench = false
 
 [dependencies]
 data-error = { path = "../data-error" }
diff --git a/fs-properties/Cargo.toml b/fs-properties/Cargo.toml
index 6ce599a8..ece81dfa 100644
--- a/fs-properties/Cargo.toml
+++ b/fs-properties/Cargo.toml
@@ -3,6 +3,10 @@ name = "fs-properties"
 version = "0.1.0"
 edition = "2021"
 
+[lib]
+name = "fs_properties"
+crate-type = ["rlib"]
+bench = false
 
 [dependencies]
 data-error = { path = "../data-error" }
diff --git a/fs-storage/Cargo.toml b/fs-storage/Cargo.toml
index 93bd7038..09fc9687 100644
--- a/fs-storage/Cargo.toml
+++ b/fs-storage/Cargo.toml
@@ -3,5 +3,9 @@ name = "fs-storage"
 version = "0.1.0"
 edition = "2021"
 
+[lib]
+name = "fs_storage"
+crate-type = ["rlib"]
+bench = false
 
 [dependencies]