Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for L1-to-DRAM resharding don't assert on bad outputs #16741

Open
esmalTT opened this issue Jan 14, 2025 · 0 comments
Open

Unit tests for L1-to-DRAM resharding don't assert on bad outputs #16741

esmalTT opened this issue Jan 14, 2025 · 0 comments
Assignees
Labels
bug Something isn't working ci-bug bugs found in CI op_cat: TM

Comments

@esmalTT
Copy link
Contributor

esmalTT commented Jan 14, 2025

Summary

I discovered that the L1-to-DRAM reshard tests don't actually assert on bad outputs:

input_shard_spec = ttnn.ShardSpec(input_shard_grid, input_shard_shape, input_shard_orientation)
input_mem_config = ttnn.MemoryConfig(input_sharding_scheme, input_buffer_type, input_shard_spec)
output_shard_spec = ttnn.ShardSpec(output_shard_grid, output_shard_shape, output_shard_orientation)
output_mem_config = ttnn.MemoryConfig(output_sharding_scheme, output_buffer_type, output_shard_spec)
input = torch.randn(input_shape).bfloat16()
input_tensor = ttnn.Tensor(input, ttnn.bfloat16).to(input_layout).to(device, input_mem_config)
output_tensor = ttnn.reshard(input_tensor, output_mem_config)
output = ttnn.to_torch(output_tensor)
passing, output_log = comp_equal(input, output)

Adding the proper assert shows that several test cases are broken.

To close this issue, we should add a proper assert and fix the broken test cases.

@esmalTT esmalTT added bug Something isn't working ci-bug bugs found in CI op_cat: TM labels Jan 14, 2025
@esmalTT esmalTT self-assigned this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci-bug bugs found in CI op_cat: TM
Projects
None yet
Development

No branches or pull requests

1 participant