Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single implementation of column type autodetection #662

Closed
2 tasks
eroell opened this issue Mar 5, 2024 · 2 comments
Closed
2 tasks

Single implementation of column type autodetection #662

eroell opened this issue Mar 5, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@eroell
Copy link
Collaborator

eroell commented Mar 5, 2024

Description of feature

Column type autodetection (e.g. whether numeric or categorical) is required at different stages of ehrapy

E.g. the autodetect option of encoding here relies on the adata.var[EHRAPY_TYPE_KEY] tag.

This is set when

  • reading a dataframe here
  • moving something from obs to X here.

We might want to harmonize that? It is the df.select_dtypes("number").columns pattern pretty consistently it appears at a first glance, but seems to be scattered.

Other places where this occurs and should be harmonized:

TODOs:

  • collect where this type detection is done
  • move it to a single implementation
@eroell eroell added the enhancement New feature or request label Mar 5, 2024
@eroell eroell self-assigned this Mar 5, 2024
@eroell
Copy link
Collaborator Author

eroell commented Mar 5, 2024

tableone might have something fairly robust we could be interested in too

@eroell eroell mentioned this issue Mar 5, 2024
4 tasks
@Lilly-May Lilly-May self-assigned this Apr 18, 2024
@Lilly-May
Copy link
Collaborator

I've merged this issue with the related issues #649 and #637 into the new issue #701 for a better overview. Therefore, I'll close this issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants