Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of pvals for volcano plots instead of FDR-corrected p-values #295

Open
ramadatta opened this issue Aug 21, 2024 · 0 comments
Open
Labels
question Further information is requested

Comments

@ramadatta
Copy link
Member

ramadatta commented Aug 21, 2024

Question

In the Single cell best practices DGE analysis, it is mentioned:

"Volcano plots are often used to visualize the results of statistical testing, and they show the change in expression on the x-axis (log-fold change) and statistical significance on the y-axis (FDR-corrected p-values)."

But in the volcano plot code, pvalue was used to plot on the y axis.

result["-logQ"] = -np.log(result["pvals"].astype("float"))

It should instead be pvals_adj (since sc_toolbox.tools.de_res_to_anndata renames FDR to pvals_adj)

I found transition from FDR -> pvals_adj -> pvals a bit confusing. Is there some specific reason, please let me know if I missing something.

@ramadatta ramadatta added the question Further information is requested label Aug 21, 2024
@ramadatta ramadatta changed the title Question about the tutorial pvalues for volcano plots instead of FDR-corrected p-values Aug 21, 2024
@ramadatta ramadatta changed the title pvalues for volcano plots instead of FDR-corrected p-values Usage of pvals for volcano plots instead of FDR-corrected p-values Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant