Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio Picos are not filtered out. #99

Open
omarshahine opened this issue Jan 15, 2023 · 9 comments
Open

Audio Picos are not filtered out. #99

omarshahine opened this issue Jan 15, 2023 · 9 comments
Labels
bug Something isn't working

Comments

@omarshahine
Copy link

Describe The Bug:
Audio Picos are not filtered out.

To Reproduce:
Install an Audio Pico

Expected behavior:
Configured Audio Pico should not be enabled.

Logs:

[15/01/2023, 12:33:01] [Lutron] Device setup finished: Set up device Kitchen Audio Pico 1
[15/01/2023, 12:33:01] [Lutron] Device setup finished: Set up device Kitchen Audio Pico 2
[15/01/2023, 12:33:01] [Lutron] Device setup finished: Set up device Living Room Audio Pico
[15/01/2023, 12:33:01] [Lutron] Device setup finished: Set up device Main Bedroom Audio Pico

Plugin Config:

{
    "name": "Lutron",
    "platform": "LutronCasetaLeap",
    "options": {
        "filterPico": true,
        "filterBlinds": false,
        "clickSpeedDouble": "default",
        "clickSpeedLong": "default"
    },
    "secrets": [
        {
            "bridgeid": "",
            "ca": "",
            "cert": "",
            "key": ""
        }
    ],
    "_bridge": {
        "username": "",
        "port":
    }
}

Screenshots:

Environment:

  • Plugin Version: v2.4.3
  • Homebridge Version: v1.6.0
  • Node.js Version: v16.16.0
  • NPM Version:
  • Operating System: Raspbian
@omarshahine omarshahine added the bug Something isn't working label Jan 15, 2023
@thenewwazoo
Copy link
Owner

thenewwazoo commented Jan 16, 2023

Oooooh tasty! Thank you for the report! I can't test this bug myself as I don't have an audio Pico, or rather I don't have a Pico associated with an audio device. Are you using it to control a Sonos?

I think I might be able to find what I need if you can enable debug logging and send me a complete log. The instructions are in the README, and I only need the output from right after Homebridge starts up. That is, I don't need to you to press buttons, wait for anything, etc: just enable logging, restart Homebridge, copy the log, disable debug logging, and restart Homebridge again to go back to normal.

@thenewwazoo
Copy link
Owner

Hi @omarshahine, any chance you can get me a debug log? I'd love to add support for audio Picos (and I can't afford to buy a Sonos for testing ;) )

@omarshahine
Copy link
Author

omarshahine commented Feb 12, 2023

Here you go https://www.icloud.com/iclouddrive/08fVUV7NkQ4ekQd8lLGC2Q56Q#homebridge.log

There are a few different picos that should be filtered out. I have a lot of them.

[12/02/2023, 07:59:33] [Lutron] Device setup finished: Skipped setting up device: Device type SmartBridge not supported by this plugin
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Skipped setting up device: Device type WallDimmer not supported by this plugin
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Skipped setting up device: Device type WallDimmer not supported by this plugin
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Skipped setting up device: Device type WallDimmer not supported by this plugin
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Skipped setting up device: Device type WallDimmer not supported by this plugin
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Skipped setting up device: Device type WallDimmer not supported by this plugin
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Skipped setting up device: Device type WallDimmer not supported by this plugin
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Skipped setting up device: Device type WallSwitch not supported by this plugin
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Skipped setting up device: Device type WallDimmer not supported by this plugin
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Skipped setting up device: Device type WallDimmer not supported by this plugin
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Skipped setting up device: Device type WallDimmer not supported by this plugin
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Skipped setting up device: Associated with a device outside HomeKit
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Skipped setting up device: Device type WallDimmer not supported by this plugin
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Skipped setting up device: Associated with a device outside HomeKit
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Skipped setting up device: Device type WallDimmer not supported by this plugin
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Skipped setting up device: Associated with a device outside HomeKit
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Skipped setting up device: Device type WallDimmer not supported by this plugin
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Skipped setting up device: Associated with a device outside HomeKit
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Skipped setting up device: Associated with a device outside HomeKit
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Skipped setting up device: Device type WallDimmer not supported by this plugin
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Set up device Kitchen Keypad
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Set up device Family Room Home Away
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Set up device Family Room Named Scene
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Skipped setting up device: Associated with a device outside HomeKit
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Set up device Bedroom Keypad 1
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Set up device Bedroom Keypad 2
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Skipped setting up device: Associated with a device outside HomeKit
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Skipped setting up device: Associated with a device outside HomeKit
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Skipped setting up device: Associated with a device outside HomeKit
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Set up device Family Room Audio Pico
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Skipped setting up device: Device type WallDimmer not supported by this plugin
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Skipped setting up device: Device type WallDimmer not supported by this plugin
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Skipped setting up device: Device type WallSwitch not supported by this plugin
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Set up device Bedroom Motion Sensor
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Set up device Main Bedroom Pico Fan
[12/02/2023, 07:59:33] [Lutron] Device setup finished: Set up device Main Bedroom Pico Blinds

@thenewwazoo
Copy link
Owner

Thank you so much for providing the log. This is super interesting. I think the only approach I can come up with is to exclude audio picos entirely, though that feels like a bad compromise.

For my own future reference, the buttongroup looks like

type OneButtonGroupDefinition with data: {
  ButtonGroup: {
    href: '/buttongroup/16',
    Buttons: [
      { href: '/button/158' },
      { href: '/button/159' },
      { href: '/button/160' },
      { href: '/button/161' },
      { href: '/button/162' }
    ],
    Parent: { href: '/device/30' },
    SortOrder: 0,
    StopIfMoving: 'Disabled',
    Category: { Type: 'Audio' },
    ProgrammingType: 'Column'
  }
}

@thenewwazoo
Copy link
Owner

I'd ideally like to only exclude audio picos that aren't associated with an audio device, but I don't see an obvious way to do that.

@hansenc0705
Copy link

Also seeing this issue as expected based off the details above. Agree that excluding all Audio Picos wouldn't be ideal.

@sdaltons1
Copy link

sdaltons1 commented Nov 19, 2024

I wonder if a better way would be to let us enter the names of picos we want to exclude into the plugin config?

Might be cleaner than trying to set up the options just right to cover the most use cases.

Something like I download the plugin, connect my hub, restart homebridge. Then a list of available picos populates. Then I can copy the names directly as they appear in the list and check a box to exclude them or "hide from Homekit" in the config, then I restart homebridge again and only those I didn't exclude remain.

I know nothing about what it would take to code this, so if it is too complex, no worries! Just a suggestion. I know the ring and govee plugins both have options to manually exclude individual devices.

@hansenc0705
Copy link

like you @sdaltons1 I don't understand the work required to do this but I think its a good solution. I don't have many of these remotes to doing a manual exclusion for them is easy enough.

@Fofer
Copy link

Fofer commented Dec 18, 2024

Hi, came here to report the same. One of mine is an actual Audio Pico (in black) and the other is just a regular Pico (in white) that I've programmed to control audio (Sonos) via the Lutron app. You set it up just like it was an Audio Pico, the two remotes are the same, aside from the labeling on the buttons themselves.

And despite the fact I've checked "Exclude Pico remotes that are associated in the Lutron app" in the config for this plugin, these two Picos are still presented to HomeKit. My other 4 regular Picos, programmed to control lights, are properly excluded. It's just the audio Picos that are not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants