-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audio Picos are not filtered out. #99
Comments
Oooooh tasty! Thank you for the report! I can't test this bug myself as I don't have an audio Pico, or rather I don't have a Pico associated with an audio device. Are you using it to control a Sonos? I think I might be able to find what I need if you can enable debug logging and send me a complete log. The instructions are in the README, and I only need the output from right after Homebridge starts up. That is, I don't need to you to press buttons, wait for anything, etc: just enable logging, restart Homebridge, copy the log, disable debug logging, and restart Homebridge again to go back to normal. |
Hi @omarshahine, any chance you can get me a debug log? I'd love to add support for audio Picos (and I can't afford to buy a Sonos for testing ;) ) |
Here you go https://www.icloud.com/iclouddrive/08fVUV7NkQ4ekQd8lLGC2Q56Q#homebridge.log There are a few different picos that should be filtered out. I have a lot of them. [12/02/2023, 07:59:33] [Lutron] Device setup finished: Skipped setting up device: Device type SmartBridge not supported by this plugin |
Thank you so much for providing the log. This is super interesting. I think the only approach I can come up with is to exclude audio picos entirely, though that feels like a bad compromise. For my own future reference, the buttongroup looks like
|
I'd ideally like to only exclude audio picos that aren't associated with an audio device, but I don't see an obvious way to do that. |
Also seeing this issue as expected based off the details above. Agree that excluding all Audio Picos wouldn't be ideal. |
I wonder if a better way would be to let us enter the names of picos we want to exclude into the plugin config? Might be cleaner than trying to set up the options just right to cover the most use cases. Something like I download the plugin, connect my hub, restart homebridge. Then a list of available picos populates. Then I can copy the names directly as they appear in the list and check a box to exclude them or "hide from Homekit" in the config, then I restart homebridge again and only those I didn't exclude remain. I know nothing about what it would take to code this, so if it is too complex, no worries! Just a suggestion. I know the ring and govee plugins both have options to manually exclude individual devices. |
like you @sdaltons1 I don't understand the work required to do this but I think its a good solution. I don't have many of these remotes to doing a manual exclusion for them is easy enough. |
Hi, came here to report the same. One of mine is an actual Audio Pico (in black) and the other is just a regular Pico (in white) that I've programmed to control audio (Sonos) via the Lutron app. You set it up just like it was an Audio Pico, the two remotes are the same, aside from the labeling on the buttons themselves. And despite the fact I've checked "Exclude Pico remotes that are associated in the Lutron app" in the config for this plugin, these two Picos are still presented to HomeKit. My other 4 regular Picos, programmed to control lights, are properly excluded. It's just the audio Picos that are not. |
Describe The Bug:
Audio Picos are not filtered out.
To Reproduce:
Install an Audio Pico
Expected behavior:
Configured Audio Pico should not be enabled.
Logs:
Plugin Config:
Screenshots:
Environment:
The text was updated successfully, but these errors were encountered: