Implement error handler #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrianLC
approved these changes
Dec 17, 2024
Comment on lines
+120
to
+131
| batchErrorHandler := csvcopy.BatchHandlerError() | ||
| if skipBatchErrors { | ||
| batchErrorHandler = csvcopy.BatchHandlerNoop() | ||
| } | ||
| if batchErrorOutputDir != "" { | ||
| log.Printf("batch errors will be stored at %s", batchErrorOutputDir) | ||
| batchErrorHandler = csvcopy.BatchHandlerSaveToFile(batchErrorOutputDir, batchErrorHandler) | ||
| } | ||
| if verbose || skipBatchErrors { | ||
| batchErrorHandler = csvcopy.BatchHandlerLog(logger, batchErrorHandler) | ||
| } | ||
| opts = append(opts, csvcopy.WithBatchErrorHandler(batchErrorHandler)) |
There was a problem hiding this comment.
Perhaps this could be extractor to an auxiliar function
There was a problem hiding this comment.
So far I think main is the best place to put this logic, moving this to a function won't make it much easier. as you need to pass all the flags.
There was a problem hiding this comment.
you can have more functions directly in the main.go file so you would still have access to the flags since they're global. It's just a way to avoid an ever-growing main function that happens as programs become more complex
Co-authored-by: Adrián López Calvo <[email protected]> Signed-off-by: Victor Perez <[email protected]>
Co-authored-by: Adrián López Calvo <[email protected]> Signed-off-by: Victor Perez <[email protected]>
Co-authored-by: Adrián López Calvo <[email protected]> Signed-off-by: Victor Perez <[email protected]>
…caledb-parallel-copy into vperez/skip-invalid-rows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a flag for the CLI to ignore error while processing a file and enables an option to store the failures as a file.
When using as a package, it exposes a callback to handle errors that can be implemented by the user application.
The location info for error has been updated as well to include the Byte position. This allows for easy recovery as you know exactly where to start reading