Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condition Check Missing in settleOrder.code #22

Open
1 of 3 tasks
ggs134 opened this issue Jul 21, 2019 · 1 comment
Open
1 of 3 tasks

Condition Check Missing in settleOrder.code #22

ggs134 opened this issue Jul 21, 2019 · 1 comment

Comments

@ggs134
Copy link
Member

ggs134 commented Jul 21, 2019

https://github.com/Onther-Tech/zk-dex/blob/dc9a4e204d09948ca573257ff8bc4b24b7ae278d/circuits/settleOrder/settleOrder.code#L94-L149

  • hash(makerNote) == newNoteToMaker.owner
  • hash(takerToMakerNote.parentNote) == newNoteToTaker.owner
  • changeNote hash check condition
@ggs134
Copy link
Member Author

ggs134 commented Jul 21, 2019

There is no way to check "hash(takerToMakerNote.parentNote) == newNoteToTaker.owner" in circuit.
(This is can be checked in smart contract)

Just need to add "hash(makerNote) == newNoteToMaker.owner" to circuit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant