Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate messaging for error validation when leaving a review #419

Open
danielngira opened this issue Dec 6, 2023 · 0 comments
Open
Labels
bug Something isn't working x/game-management
Milestone

Comments

@danielngira
Copy link
Contributor

danielngira commented Dec 6, 2023

In PR #261, we added the ability to leave a review and rating on a game in the game detail page that was implemented in issue #40. One of the conditions for leaving a review is that either the review or the rating must be field. That is they can't both be left blank. By the end of issue #261 the form validated this correctly. However, if you try to leave both of the fields blank, it will give off two error messages. In this issue, you will fix this issue that arises from the ReviewForm so that it only gives off one error message. Here is a visual of what you are meant to fix.

Image

@danielngira danielngira converted this from a draft issue Dec 6, 2023
@danielngira danielngira added bug Something isn't working x/game-management labels Dec 6, 2023
@majorsylvie majorsylvie added this to the Backlog milestone Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working x/game-management
Projects
Status: Backlog
Development

No branches or pull requests

2 participants