Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the filename for non-integer output frequency #826

Closed
junwang-noaa opened this issue Sep 23, 2021 · 8 comments
Closed

fix the filename for non-integer output frequency #826

junwang-noaa opened this issue Sep 23, 2021 · 8 comments
Labels
bug Something isn't working

Comments

@junwang-noaa
Copy link
Collaborator

Description

It was found that the filename does not reflect the correct output time when the non-integer output frequency is used. This is true for both model history files and post process files from inline post.

To Reproduce:

What compilers/machines are you seeing this with?
Give explicit steps to reproduce the behavior.

  1. checkout ufs-weather-model
  2. just run control test: cd ufs-weather-model/tests; rt.sh -n "control"
  3. in the control run directory, change the line of output_fh: in model_configure
    output_fh: 0.4 -1
  4. run the test by: sbatch job_card
  5. the results show the history files at non-integer forecast hours are missing
@junwang-noaa junwang-noaa added the bug Something isn't working label Sep 23, 2021
@junwang-noaa
Copy link
Collaborator Author

@WenMeng-NOAA do we need any changes in post to get full time stamp (e.g. fhour-fhmin-fsec) in the post output file names?

@WenMeng-NOAA
Copy link
Contributor

@junwang-noaa Let me look into the UPP code and get back to you later.

@WenMeng-NOAA
Copy link
Contributor

@junwang-noaa The changes might be needed in UPP routine get_postfilename.f
https://github.com/NOAA-EMC/UPP/blob/develop/sorc/ncep_post.fd/get_postfilename.f#L102
How do you like to change model history file and post output file naming conventions?

@junwang-noaa
Copy link
Collaborator Author

@WenMeng-NOAA Currently model history file names with full time stamp are using 3 digits for hours, 2 digits for minutes and 2 digits for seconds. E.g.:
atmf000-12-00.nc
atmf001-12-00.nc
sfcf000-12-00.nc
sfcf001-12-00.nc

@WenMeng-NOAA
Copy link
Contributor

@junwang-noaa I will test the changes in UPP code.

@junwang-noaa junwang-noaa mentioned this issue Sep 30, 2021
Merged
14 tasks
@junwang-noaa
Copy link
Collaborator Author

@WenMeng-NOAA The issue with model history file names was fixed and committed to ufs-weather-model repository. Do you want me to create an issue at UPP repo? So once UPP has this issue fixed, we will update ufs to use the UPP lib with the fix.

@WenMeng-NOAA
Copy link
Contributor

@junwang-noaa Yes, please open an issue in UPP repos..

@junwang-noaa
Copy link
Collaborator Author

Post issue #401 was created. I will close this issue.

epic-cicd-jenkins pushed a commit that referenced this issue Apr 17, 2023
@michelleharrold
Mods to METplus vx to address multiple issues (#826)
f870a53 
* Mods to METplus conf files: TCDC specifications, correction to level specificatons in point-stat mean and prob files, and added functionality to make METplus output dirs in ex scripts.

* Updated comments in MET ex-scripts for creating output directories.

* Fixed minor formatting issue in exregional_run_gridstatvx.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@junwang-noaa @WenMeng-NOAA