Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide on names for icu_datetime and icu_calendar errors over FFI #5274

Open
sffc opened this issue Jul 19, 2024 · 4 comments
Open

Decide on names for icu_datetime and icu_calendar errors over FFI #5274

sffc opened this issue Jul 19, 2024 · 4 comments
Assignees
@sffc
Labels
C-datetime Component: datetime, calendars, time zones S-small Size: One afternoon (small bug fix or enhancement)
Milestone
ICU4X 2.0 ⟨P1⟩

Comments

@sffc
Copy link
Member

sffc commented Jul 19, 2024

icu_datetime and icu_calendar have many new, small error enums. We should discuss their naming conventions.

One example which isn't super great is that icu_calendar::ParseError is currently exported as CalendarParseError, even though it is the error resulting from parsing an IXDTF string to a Date, Time, or DateTime. (#5260)
@sffc sffc added the C-datetime Component: datetime, calendars, time zones label Jul 19, 2024
@sffc sffc added this to the ICU4X 2.0 ⟨P1⟩ milestone Jul 19, 2024
@sffc sffc added this to icu4x 2.0 Jul 19, 2024
@sffc sffc moved this to Needs discussion to unblock in icu4x 2.0 Jul 19, 2024
@sffc sffc mentioned this issue Jul 19, 2024
Merged
@sffc sffc added the discuss-priority Discuss at the next ICU4X meeting label Jul 23, 2024
@sffc
Copy link
Member Author

sffc commented Jul 25, 2024

I want to save this discussion until after neo datetime is fully landed so that we can see exactly which error enums we're having to name in FFI.

@sffc sffc added discuss Discuss at a future ICU4X-SC meeting and removed discuss-priority Discuss at the next ICU4X meeting labels Jul 25, 2024
@sffc
Copy link
Member Author

sffc commented Sep 17, 2024

Part of the 2.0 FFI audit

@sffc
Copy link
Member Author

sffc commented Oct 23, 2024

@robertbastian says he's fine with names so long as they are targeted/descriptive as opposed to reliant on the crate name.

@sffc sffc added S-small Size: One afternoon (small bug fix or enhancement) and removed discuss Discuss at a future ICU4X-SC meeting labels Jan 7, 2025
@Manishearth
Copy link
Member

This is blocked on #5940

We don't seem to need a discussion yet, Shane plans to make a PR when ready and we can discuss if there is controversy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sffc sffc

Labels
C-datetime Component: datetime, calendars, time zones S-small Size: One afternoon (small bug fix or enhancement)
Projects
icu4x 2.0
Status: Needs discussion to unblock
Milestone
ICU4X 2.0 ⟨P1⟩
Development

No branches or pull requests
2 participants
@sffc @Manishearth