Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datetime benchmark uploading and document #5865

Open
sffc opened this issue Nov 23, 2024 · 2 comments
Open

Fix datetime benchmark uploading and document #5865

sffc opened this issue Nov 23, 2024 · 2 comments
Assignees
Labels
C-process Component: Team processes S-small Size: One afternoon (small bug fix or enhancement)

Comments

@sffc
Copy link
Member

sffc commented Nov 23, 2024

Since about 2024-11-15, the datetime benchmarks have not been uploading successfully.

image

The benchmark CI has failed in a similar way before, and @robertbastian has always fixed it. We should document how to go about fixing it so as to not have a single point of failure.

@sffc sffc added the C-process Component: Team processes label Nov 23, 2024
@sffc sffc added this to the ICU4X 2.0 ⟨P1⟩ milestone Nov 23, 2024
@Manishearth
Copy link
Member

This is no longer a 2.0 blocker (the benchmark fixed itself), but we should still document things.

@Manishearth Manishearth added the S-small Size: One afternoon (small bug fix or enhancement) label Jan 7, 2025
@robertbastian
Copy link
Member

This is not an upload error. The benchmark failed (even though the "Run benchmark" step doesn't report as failing), so there's nothing to upload. I have previously fixed it by fixing the benchmark code, which for some reason is not tested in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-process Component: Team processes S-small Size: One afternoon (small bug fix or enhancement)
Projects
None yet
Development

No branches or pull requests

3 participants