Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move a few straggling dependencies to workspace Cargo.toml #5866

Open
sffc opened this issue Nov 23, 2024 · 2 comments
Open

Move a few straggling dependencies to workspace Cargo.toml #5866

sffc opened this issue Nov 23, 2024 · 2 comments
Labels
C-process Component: Team processes S-small Size: One afternoon (small bug fix or enhancement)

Comments

@sffc
Copy link
Member

sffc commented Nov 23, 2024

As part of the 2.0.0-beta1 release checklist, I found a few crates that have dependencies that aren't in the workspace:

  • components/normalizer/fuzz
  • ffi/ecma402
  • ffi/freertos
  • tools/benchmark/macros
  • tools/benchmark/memory
  • tools/make/diplomat-coverage
  • utils/bies
  • utils/env_preferences
  • utils/potential_utf (dev deps)

Maybe some of these should start using workspace dependencies. For ones that don't, maybe explicitly say that they are excluded in the release checklist.

@sffc sffc added this to the ICU4X 2.0 Stretch ⟨P2⟩ milestone Nov 23, 2024
@Manishearth Manishearth added the S-small Size: One afternoon (small bug fix or enhancement) label Jan 7, 2025
@sffc sffc added the C-process Component: Team processes label Jan 7, 2025
@robertbastian
Copy link
Member

  • components/normalizer/fuzz

This is not part of the workspace, and is publish=false

  • ffi/ecma402
  • ffi/freertos

I purposely didn't use workspace deps for the ecma402 traits and freertos, because no other crates should ever need them, and it's useful to be able to figure out the version without going to workspace deps.

  • tools/benchmark/macros
  • tools/benchmark/memory
  • tools/make/diplomat-coverage

It's nice for the workspace list to match the deps of ICU4X (icu/icu_capi/icu4x-datagen), and to not have random tool deps in them.

  • utils/bies
  • utils/env_preferences

Same here, these are not ICU4X deps...

  • utils/potential_utf (dev deps)

Sure

@sffc
Copy link
Member Author

sffc commented Jan 8, 2025

"I found a few crates that have dependencies that aren't in the workspace"

For example, the crate at tools/benchmark/macros depends on dhat = { version = "0.3", optional = true }. This issue is to decide whether that should be dhat = { workspace = true, optional = true } (I think it should) and then implement it across the crates listed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-process Component: Team processes S-small Size: One afternoon (small bug fix or enhancement)
Projects
None yet
Development

No branches or pull requests

3 participants