Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current release nominally incompatible with Sphinx >= 5 #12

Closed
sleiner opened this issue May 30, 2023 · 7 comments
Closed

Current release nominally incompatible with Sphinx >= 5 #12

sleiner opened this issue May 30, 2023 · 7 comments

Comments

@sleiner
Copy link

sleiner commented May 30, 2023

The current released version of this package (1.2.2) requires Sphinx to be <5,>4. This means it would be incompatible with all Sphinx versions from 5.0 on. In my experience, it works just fine, but it is a problem when using strict dependency managers such as PDM, which (as far as I can tell, rightfully) reports:

% pdm add sphinx-data-viewer
Adding packages to default dependencies: sphinx-data-viewer
🔒 Lock failed
Unable to find a resolution for sphinx
because of the following conflicts:
  sphinx<5,>=4 (from [email protected])
  sphinx<5,>=4 (from [email protected])
  sphinx<5,>=4 (from [email protected])
  sphinx>=7.0.1 (from project)
To fix this, you could loosen the dependency version constraints in pyproject.toml. See https://pdm.fming.dev/latest/usage/dependency/#solve-the-locking-failure for more details.
See /var/folders/vx/hn90mz9j7x1bw6j_msm723h80000gn/T/pdm-lock-lj7c7wo_.log for detailed debug log.
[ResolutionImpossible]: Unable to find a resolution
Add '-v' to see the detailed traceback

Proposed fix

Since 720c7f3, there is no more upper bound on Sphinx. So releasing the current state main would solve the issue :-)

@sigma67
Copy link

sigma67 commented Jul 11, 2023

@useblocks any plans to publish a release?

@sigma67
Copy link

sigma67 commented Aug 12, 2023

@danwos @iSOLveIT perhaps? :)

@danwos
Copy link
Member

danwos commented Aug 14, 2023

Sorry for the "short" delay. Mea culpa.

I just want to merge also PR #10, which adds jquery support for the newer Sphinx versions.

@sigma67
Copy link

sigma67 commented Oct 25, 2023

It seems there is nothing happening on #10 .. would you mind creating a release to at least fix the issue mentioned in this thread?

@sigma67
Copy link

sigma67 commented Jan 25, 2024

@danwos It's 2024 and this package is still on sphinx<5, can we please have a release? 🙏

@danwos
Copy link
Member

danwos commented Jan 25, 2024

Got released with 0.1.3, sorry for the annoying delay.

@danwos danwos closed this as completed Jan 25, 2024
@sigma67
Copy link

sigma67 commented Jan 25, 2024

Amazing, thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants