Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown fields open / close overlay inconsistently on label click #8262

Open
web-padawan opened this issue Dec 3, 2024 · 0 comments
Open

Comments

@web-padawan
Copy link
Member

web-padawan commented Dec 3, 2024

Describe your motivation

Originally reported in #7812 (comment) but that issue was related to focus / blur and this one is about opened state.

Currently, our field components work differently on label click since they have different logic:

ComboBox

  • Opens overlay on label element click
  • Closes on subsequent label click ("outside click" logic applies) and then re-opens immediately
combo-label-click.mp4

DatePicker

  • Opens overlay on label element click
  • Doesn't close on subsequent label click (as the vaadin-overlay-close on outside click is prevented)
date-picker-label-click.mp4

TimePicker & MultiSelectComboBox

  • Doesn't open overlay on label element click
  • Closes on label click when opened ("outside click" logic applies)
time-picker-label-click.mp4

Select

  • Opens overlay on label element click
  • Closes overlay on subsequent label click
select-label-click.mp4

Describe the solution you'd like

IMO we should consider aligning components to behave either like DatePicker or like Select.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant