Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch of displayoption values when upgrading from Epibootstrap.area #122

Open
nguyejon-te opened this issue Oct 18, 2024 · 0 comments
Open

Comments

@nguyejon-te
Copy link

Just wanted to point out that there is a mismatch in displayoption values when upgrading from Optimizely CMS 11 to 12. In the old project EpiBootstrapArea was used and the display option values were set in the following way:

options.Add(new DisplayOption { Id = mode.Tag, Name = translatedName, Tag = mode.Tag, IconClass = mode.Icon }); (found in the branch epi10 - assuming this is similar to the Epibootraparea version 5.3.3 used in our older project)

In the latest version the options are added in the following way:

displayOption.Add(displayOption.Id, displayOption.Name, displayOption.Tag, "", displayOption.Icon);

The list of addon displayoptions didn't have the id property in the past and the Tag-property was passed for the Id property of the displayoption. The new list of addon display options have the id field and that value does not derive from the CmsContentAreaTags, but is set statically as full, half etc.

This issue causes the new version to be incompatible as is to replace the old version. Work around to fix the issue is to set up a list of displayoptions in your project locally and replace the initialisation to use those values that match the old version instead.

Not an issue if this is being used for the first time, but can cause issues with migration projects where previous default values were used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant