-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated libraries list with those that support Vapor 4.0. #86
Comments
Woo, thank you for your work, that’s an amazing help for sure! Can I ask for two things first, though?
Thank you again and I’m looking forward to the pull request! |
Happy to make those changes and have a few that are no longer support that can be deleted. I don’t know how to create a pull request. Happy to learn, just no idea what to do.
/carmi
… On Sep 30, 2021, at 5:45 PM, Milan Vit ***@***.***> wrote:
Woo, thank you for your work, that’s an amazing help for sure!
Can I ask for two things first, though?
Instead of submitting this as an issue, could you fork the repository, commit your changes on a new branch and submit a pull request against this repository, please? That way, we can discuss the individual code-level details better.
I think that in order to not lose the filtered for Vapor 3 compatibility list (and at the same time not to have many entries duplicated twice in the main list), the libraries, frameworks and entries that support (or at some point supported) Vapor 3 should have both Vapor 3’s and Vapor 4’s icon on a single line. Kind of like this in the past, when we had a lot of libraries with both Vapor 2 & Vapor 3 compatibility: 516f571#diff-45c6dc1ce947996409b06d7f3e7d8125fb44d29b39ae969d268928157c3306bbR33-R38 <516f571#diff-45c6dc1ce947996409b06d7f3e7d8125fb44d29b39ae969d268928157c3306bbR33-R38>
Thank you again and I’m looking forward to the pull request!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#86 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJK5BLFVKTSTN6CHUDOJQDUEUABDANCNFSM5FBKOOPQ>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Did as you asked (sort of). :-) I didn't really fill in the pull request correctly, but it is not really the same kind of request. I will start looking for libraries to add as soon as I have some more time. |
Thank you so much, and sorry for the lack of updates from my side! Things have been quite hectic recently… will try to review/change/approve by the end of the week! 🤞 |
README.md
I updated all those packages that already support 4.0. I also deleted the two dead vapor services and the dead VaporNation newsletter.
I also request information on whether packages were still under development from a number of people and will update as I hear.
The text was updated successfully, but these errors were encountered: