From 90b8e3303640611c0011dbd86ba3b86d257b8109 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?I=C3=B1aki=20Baz=20Castillo?= <ibc@aliax.net>
Date: Sat, 25 Nov 2023 13:33:17 +0100
Subject: [PATCH] npm-scripts.mjs: remove old msys stuff

- Plus cosmetic changes in CI files
---
 .github/workflows/mediasoup-worker-prebuild.yaml | 8 ++++----
 .github/workflows/mediasoup-worker.yaml          | 8 ++++----
 npm-scripts.mjs                                  | 8 --------
 3 files changed, 8 insertions(+), 16 deletions(-)

diff --git a/.github/workflows/mediasoup-worker-prebuild.yaml b/.github/workflows/mediasoup-worker-prebuild.yaml
index 7260e2fca4..ea1491cf72 100644
--- a/.github/workflows/mediasoup-worker-prebuild.yaml
+++ b/.github/workflows/mediasoup-worker-prebuild.yaml
@@ -54,10 +54,10 @@ jobs:
       - name: npm ci
         run: npm ci --ignore-scripts --omit=dev
 
-      # However we also need to install pip invoke by manually invoking the NPM
-      # 'preinstall' script (since `--ignore-scripts` above made it not run).
-      - name: npm run preinstall
-        run: npm run preinstall
+      # However we also need to install pip invoke manually (since
+      # `--ignore-scripts` prevented invoke from being installed).
+      - name: pip3 install invoke
+        run: pip3 install invoke
 
       - name: npm run worker:build
         run: npm run worker:build
diff --git a/.github/workflows/mediasoup-worker.yaml b/.github/workflows/mediasoup-worker.yaml
index 304e0741c0..104ff9aa89 100644
--- a/.github/workflows/mediasoup-worker.yaml
+++ b/.github/workflows/mediasoup-worker.yaml
@@ -68,10 +68,10 @@ jobs:
       - name: npm ci
         run: npm ci --ignore-scripts --omit=dev
 
-      # However we also need to install pip invoke by manually invoking the NPM
-      # 'preinstall' script (since `--ignore-scripts` above made it not run).
-      - name: npm run preinstall
-        run: npm run preinstall
+      # However we also need to install pip invoke manually (since
+      # `--ignore-scripts` prevented invoke from being installed).
+      - name: pip3 install invoke
+        run: pip3 install invoke
 
       # We need to install deps on worker/scripts/package.json.
       - name: npm run install-worker-dev-tools
diff --git a/npm-scripts.mjs b/npm-scripts.mjs
index bd347c83fe..82cbb6b3d8 100644
--- a/npm-scripts.mjs
+++ b/npm-scripts.mjs
@@ -379,14 +379,6 @@ function cleanWorkerArtifacts()
 	executeCmd(`${PYTHON} -m invoke -r worker clean-subprojects`);
 	// Clean PIP/Meson/Ninja.
 	executeCmd(`${PYTHON} -m invoke -r worker clean-pip`);
-
-	if (IS_WINDOWS)
-	{
-		if (fs.existsSync('worker/out/msys'))
-		{
-			executeCmd('rd /s /q worker\\out\\msys');
-		}
-	}
 }
 
 function lintNode()