Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust docs for 0.13 failed to build #1270

Closed
PaulOlteanu opened this issue Dec 18, 2023 · 4 comments · Fixed by #1271
Closed

Rust docs for 0.13 failed to build #1270

PaulOlteanu opened this issue Dec 18, 2023 · 4 comments · Fixed by #1271
Labels

Comments

@PaulOlteanu
Copy link
Contributor

Bug Report

Issue description

The docs for release 0.13 of mediasoup for rust failed to build. Here's a direct link to the error.

I can't really try and help more in depth at the moment, but I do know you can try building docs locally to test the build https://github.com/rust-lang/docs.rs#build-subcommand.

@nazar-pc
Copy link
Collaborator

The reason is that we skip the whole build script for build.rs:

if env::var("DOCS_RS").is_ok() {
// Skip everything when building docs on docs.rs
return;
}

Now that we have flatbuffers (that we thankfully compile with Rust code) we need to move that check below flatbuffers compilation.

@PaulOlteanu would you mind sending a PR to fix this, please?

@ibc
Copy link
Member

ibc commented Dec 18, 2023

To here?

@nazar-pc
Copy link
Collaborator

Exactly, just move the check there and it should succeed.

ibc added a commit that referenced this issue Dec 18, 2023
@ibc
Copy link
Member

ibc commented Dec 18, 2023

#1271

@ibc ibc closed this as completed in #1271 Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

3 participants