Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution for #37 is actually wrong, I believe #67

Open
mcepl opened this issue Dec 17, 2020 · 0 comments
Open

Solution for #37 is actually wrong, I believe #67

mcepl opened this issue Dec 17, 2020 · 0 comments

Comments

@mcepl
Copy link

mcepl commented Dec 17, 2020

as_string = note_re.sub('', '\n'.join(input_lines))
if _is_blank(as_string):
continue
paragraph = InputParagraph(as_string.split('\n'))

With this code the codes are ignored when parsing .fountain source document. I believe this is the wrong solution for #37; according to https://fountain.io/syntax#section-notes:

Notes are designed to be compatible with the types of inserted annotation common in screenwriting software, e.g. Final Draft's Scriptnotes. To hide, or "comment out" sections of text, use the boneyard syntax.

which seems to imply to me, that (contrary to boneyards) notes should not be hidden, but displayed in some special way (different colour?), so they are outstanding from the text. They should be used for internal meta-comments (“This needs more work.” or “Thank you for this idea to John Smith.”), displayed, but they are not part of the action on the screen itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant