Add custom paths feature #168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add throttling to pointer move event Fixes #163 Add throttling to pointer move events in the Canvas component to optimize coordinate recording. - Modify `packages/react-sketch-canvas/src/Canvas/index.tsx` to add throttling to the `handlePointerMove` function using a custom `useThrottledCallback` function. - Add `throttleTime` to `CanvasProps` in `packages/react-sketch-canvas/src/Canvas/types.ts` with a default value of 20. - Add `throttleTime` to `ReactSketchCanvasProps` in `packages/react-sketch-canvas/src/ReactSketchCanvas/types.ts` with a default value of 20. - Add `useThrottledCallback` function in `packages/react-sketch-canvas/src/Canvas/utils.tsx` to throttle a callback function. - Update `README.md` to include documentation on the new `throttleTime` configuration option. - Add tests to verify throttling behavior in `packages/tests/src/actions/throttling.spec.ts`. - Write vitest tests for `useThrottledCallback` function in `packages/react-sketch-canvas/src/Canvas/__test__/utils.test.tsx`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/vinothpandian/react-sketch-canvas/issues/163?shareId=XXXX-XXXX-XXXX-XXXX). * fix: tests * fix: set default throttleTime to 0 * chore: remove lint in ci * fix: workflow
Fixes #143 Add support for custom path generator in `ReactSketchCanvas`. * Add `getSvgPathFromPoints` prop to `ReactSketchCanvas` component to accept a callback function for custom path generation. * Pass `getSvgPathFromPoints` prop to `Canvas` component. * Add `getSvgPathFromPoints` prop to `Canvas` component to accept a callback function for custom path generation. * Pass `getSvgPathFromPoints` prop to `SvgPath` component. * Modify `SvgPath` component to use the custom path generator if provided. * Update documentation in `README.md` to include the new `getSvgPathFromPoints` prop and its usage. * Add tests in `export.spec.tsx` to verify the functionality of the custom path generator. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/vinothpandian/react-sketch-canvas/issues/143?shareId=XXXX-XXXX-XXXX-XXXX).
vinothpandian
force-pushed
the
add-custom-paths
branch
from
cd8693b to
2a6b5b4
Compare
|
Hi @vinothpandian , any plan to merge it soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143
Add support for custom path generator in
ReactSketchCanvas.getSvgPathFromPointsprop toReactSketchCanvascomponent to accept a callback function for custom path generation.getSvgPathFromPointsprop toCanvascomponent.getSvgPathFromPointsprop toCanvascomponent to accept a callback function for custom path generation.getSvgPathFromPointsprop toSvgPathcomponent.SvgPathcomponent to use the custom path generator if provided.README.mdto include the newgetSvgPathFromPointsprop and its usage.export.spec.tsxto verify the functionality of the custom path generator.For more details, open the Copilot Workspace session.