Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17 condition selector #126

Open
wants to merge 156 commits into
base: dev
Choose a base branch
from
Open

17 condition selector #126

wants to merge 156 commits into from

Conversation

bbollen23
Copy link

@bbollen23 bbollen23 commented Oct 8, 2024

Does this PR close any open issues?

Closes #17, #66 , #67, #130, #129, #128, #134, #138

Give a longer description of what this PR addresses and why it's needed

Goal of this PR is to create the condition selector view and finish the general filtering based on condition selection.

Provide pictures/videos of the behavior before and after these changes (optional)

TODOs:

  • Implement condition selector as a component
  • Connect filtering from condition selector and filter view to other views
  • Implement selections and filtering from sidebar affecting Line Chart and Image Vue
  • Add track level attributes filtering
  • Connect filter views to condition chart using mosaic
  • Add additional cell-level attributes (which are derived) [Brian]
  • Add growth rate (lin regression slope for mass) [Brian]
  • Add support for dark mode (condition selector drop-down and condition selector legend) [Luke]
  • Add the combined version of the condition selector plot. This is the "Compare" tab in Loon. [Brian/Luke]
  • Add filtering in other charts (e.g. distributions) based on currently selected conditions. [Brian]
  • Remove test page stuff
  • add dropdown for selecting attribute to plot in condition plots [Luke]
  • add legend for comparison view
  • Fix bug: selecting a location triggers the select all button action in the condition chart.
  • fix bug: refreshing does not work if the filter panel is open
  • Image view: do not black out cells that are filtered out
  • Image view: when no highlights are applied cell outlines should show (similar to how they would if all data was highlighted)
  • Changing a condition filter should update the currently selected location if that location was filtered out.
  • Github Action: either run yarn run pretty as a github action, or add a linting rule that prevents committing if there are prettier linting issues.
  • Fix bug: Changing experiment throws mosaic error when experiment already selected (to fix: condition selector store needs to be reset when changing to new experiment. Under the hood, selected grid also contains all experiments from previous experiments)
  • When loading experiment, initial location should be chosen
  • Fix: Invalid location shows errors but also immovable loading symbol
  • Fix: Refresh now showing image vue having filtered out items (On load, filters are technically changed. Filter predicate requires both selection and filter predicates. Even though no filter is applied, it will still use existing selection predicate.)
  • Notification should be shown when location changes from condition selector
  • Fix: Cell Image vue selection not working on refresh

@bbollen23 bbollen23 changed the base branch from main to dev October 8, 2024 14:44
Luke-Schreiber and others added 28 commits October 8, 2024 14:29
…said store. Added another test page -- will be removed during PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants