forked from visdesignlab/aardvark
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
17 condition selector #126
Open
bbollen23
wants to merge
156
commits into
dev
Choose a base branch
from
17-condition-selector
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ab/loonar into 17-condition-selector
…hanged in condition selector.
…ab/loonar into 17-condition-selector
…moved borders on condition selector.
…said store. Added another test page -- will be removed during PR
Dev-Lan
requested changes
Dec 20, 2024
apps/client/src/components/conditionSelector/ConditionChart.vue
Outdated
Show resolved
Hide resolved
…st doesn't change element if location can't be loaded.
Dev-Lan
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
Closes #17, #66 , #67, #130, #129, #128, #134, #138
Give a longer description of what this PR addresses and why it's needed
Goal of this PR is to create the condition selector view and finish the general filtering based on condition selection.
Provide pictures/videos of the behavior before and after these changes (optional)
TODOs:
yarn run pretty
as a github action, or add a linting rule that prevents committing if there are prettier linting issues.