-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deepCopy, hasOwn, emotion, and config files #437
Open
JakeWags
wants to merge
13
commits into
main
Choose a base branch
from
component-integration-fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Update configuration files to resolve install-time errors in other environments
✅ Deploy Preview for upset2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
deepCopy
documentation to reflect actual usage.Update
structuredClone
usage in project to use version-safedeepCopy
.Update instances of
Object.hasOwn
to prototype version for esnext typescript versioning issues. May be resolved with typescript config changes, however.Remove extraneous emotion jsx compiler statements (this is included in the tsconfig)
Update configuration files (package.json, tsconfig, vite config) to resolve install-time errors in other environments.
Does this PR close any open issues?
Closes #405
Give a longer description of what this PR addresses and why it's needed
No visible changes to the app, just config updates and some typescript version related changes for compatibility when installed as a node module. This is prep for 1.0 react component release.
Have you added or updated relevant tests?
Have you added or updated relevant documentation?
Are there any additional TODOs before this PR is ready to go?
TODOs: