Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abundance of logging everywhere #48

Open
codistiano opened this issue Oct 3, 2024 · 4 comments
Open

Abundance of logging everywhere #48

codistiano opened this issue Oct 3, 2024 · 4 comments
Assignees
Labels

Comments

@codistiano
Copy link
Contributor

It's not recommended to use console.log in production code because:

  • It might expose sensitive information
  • It might also change how the code and how it runs, making it difficult to track unsteady behaviors
  • It also can cause code to break on older browsers
  • And when in development, it can be time consuming to sift through logs.
@codistiano
Copy link
Contributor Author

codistiano commented Oct 3, 2024

The solution would be removing every logging code or if keeping it is still necessary, a statement can be created that checks if it is in production phase it would make all the log not to work

@vishalverma9572
Copy link
Owner

@codistiano, can you ensure the logs only appear if the environment is in development? In deployment, avoid logging. This will help developers understand things better without unnecessary logs in production

codistiano added a commit to codistiano/QuizMaster that referenced this issue Oct 4, 2024
vishalverma9572 added a commit that referenced this issue Oct 5, 2024
fixed: Abundance of logging everywhere #48
@vishalverma9572
Copy link
Owner

@codistiano, Hey! After merging your commit, the server crashed, so I had to revert it. Please fix the issue and create a new PR. Let me know once it's done.

@codistiano
Copy link
Contributor Author

codistiano commented Oct 6, 2024

I will check the logs and fix the problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants