Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vretry_test.v fails on OpenMandriva builder #23398

Open
davidebeatrici opened this issue Jan 7, 2025 · 4 comments
Open

vretry_test.v fails on OpenMandriva builder #23398

davidebeatrici opened this issue Jan 7, 2025 · 4 comments
Labels
Bug This tag is applied to issues which reports bugs. Testing Bugs/feature requests, that are related to testing framework, `test_` functions and `_test.v` files.

Comments

@davidebeatrici
Copy link
Contributor

davidebeatrici commented Jan 7, 2025

Describe the bug

All tests succeed except for vretry_test.v:

DEBUG:  FAIL  [ 196/2214] C:  1112.0 ms, R:  9526.420 ms cmd/tools/vretry_test.v
DEBUG: /builddir/build/BUILD/vlang-0.4.9-build/v-0.4.9/cmd/tools/vretry_test.v:38: fn test_retry
DEBUG:    > assert res.exit_code == 0
DEBUG:      Left value (len: 3): `128`
DEBUG:     Right value (len: 1): `0`

Reproduction Steps

v cmd/tools/vretry_test.v

Expected Behavior

The test to succeed.

Current Behavior

The test fails.

Possible Solution

No response

Additional Information/Context

Full log: https://file-store.openmandriva.org/api/v1/file_stores/568a50eebd6cc3fbcd4ec41c685a2e877e2a1fa9.log?show=true

V version

0.4.9

Environment details (OS name and version, etc.)

OpenMandriva on x86_64.

Note

You can use the 👍 reaction to increase the issue's priority for developers.

Please note that only the 👍 reaction to the issue itself counts as a vote.
Other reactions and those to comments will not be taken into account.

Huly®: V_0.6-21829

@davidebeatrici davidebeatrici added the Bug This tag is applied to issues which reports bugs. label Jan 7, 2025
@JalonSolov
Copy link
Contributor

Another OpenMandriva specific issue... here, I get

$ v test cmd/tools/vretry_test.v
---- Testing... ----------------------------------------------------------------------------------------------------------------------------
 OK     602.667 ms cmd/tools/vretry_test.v
--------------------------------------------------------------------------------------------------------------------------------------------
Summary for all V _test.v files: 1 passed, 1 total. Elapsed time: 746 ms, on 1 job. Comptime: 142 ms. Runtime: 602 ms.
$

@JalonSolov
Copy link
Contributor

If I try without the test part, I get

$ v cmd/tools/vretry_test.v
$

@JalonSolov
Copy link
Contributor

That test just tries to run 3 git commands... the first is expected to fail, but the other 2 definitely will if you don't run the test from a git repo.

@davidebeatrici
Copy link
Contributor Author

Which is what I thought... I believe the test should be changed to use a command that is guaranteed to succeed (i.e. doesn't rely on the folder being a Git repository).

@felipensp felipensp added the Testing Bugs/feature requests, that are related to testing framework, `test_` functions and `_test.v` files. label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This tag is applied to issues which reports bugs. Testing Bugs/feature requests, that are related to testing framework, `test_` functions and `_test.v` files.
Projects
None yet
Development

No branches or pull requests

3 participants