Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Support newer versions of Node #10

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

WIP: Support newer versions of Node #10

wants to merge 4 commits into from

Conversation

jmealo
Copy link

@jmealo jmealo commented Jan 17, 2024 •
edited
Loading

I'm not sure if you're looking to collaborate, but, here's what I've done so far :)

  • Upgraded TAP to fix issues running tests on Node 16 and higher (Fixes: Node 16+ tests fail to run: Error: Cannot find module './reports/base' #9)
  • Used native assert module to replace deprecated TapJS methods
  • Upgrade to supported non-EOL versions of Node: 16, 18, 20
  • Upgraded the docker-compose and relevant scripts to run against: 5.7, 8.1 (without compression) and 8.2 (with compression)

There's some tests failing, but, things look mostly good. There's a really good chance that upgrading TAP may have introduced these failures; I'm not familiar enough with the suites at this point to know.

 FAIL  test/types.js 2 failed of 805 5.387s
 ✖ json > should be equal
    test/helpers/expectEvents.js                                                              
    18       expectEvents(test, events, expected, multiplier, callback, (waitIndex || 0) + 1);
    19     }, MAX_WAIT / 10);                                                                 
    20   } else {                                                                             
    21     test.equal(events.length, expected.length * multiplier);                           
    ━━━━━━━━━━━━┛                                                                             
    22     events.forEach(function(event, index) {                                            
    23       const exp = expected[index % expected.length];                                   
    24       for (const i in exp) {                                                           
    25         if (Object.prototype.hasOwnProperty.call(exp, i)) {                            
    --- expected   
    +++ actual     
    @@ -1,1 +1,1 @@
    -186           
    +53            
    compare: ===
    expectEvents (test/helpers/expectEvents.js:21:10)
    Timeout._onTimeout (test/helpers/expectEvents.js:18:7)

@jmealo
Copy link
Author

jmealo commented Jan 18, 2024

MySQL 5.7 is EoL as of November 2023, it might make sense to remove these from tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node 16+ tests fail to run: Error: Cannot find module './reports/base'
1 participant
@jmealo