Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

CI pipeline setup for pull request validation #5

Open
piyusql opened this issue Apr 3, 2023 · 3 comments
Open

CI pipeline setup for pull request validation #5

piyusql opened this issue Apr 3, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@piyusql
Copy link
Contributor

piyusql commented Apr 3, 2023

Is your feature request related to a problem? Please describe.

Currently we do test and build at local machine using tox.
we are willing to integrate this with each pull request so that it will be validated before getting merged.

Describe the solution you'd like

We have the following 4 steps which we want to run as part of CI pipeline to test and validate.

  • make test
  • source venv/bin/activate && tox
  • python -m pip install --upgrade build
  • python -m build
    These command should run automatically whenever a new PR arrives or an old PR is updated.

Describe alternatives you've considered

Manual test what we are doing as of now is not adequate for all MR.

Additional context

No response

@preyunk
Copy link
Contributor

preyunk commented Apr 22, 2023

Can we close this issue?
@kartikeyangupta @piyusql

@piyusql
Copy link
Contributor Author

piyusql commented May 24, 2023

We have seen it's having issues running in python2.7, Ref #32

@kartikeyangupta
Copy link
Contributor

looking into this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants