Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selinux::module fails when module contains more than .te file #118

Closed
maage opened this issue Sep 4, 2016 · 3 comments
Closed

selinux::module fails when module contains more than .te file #118

maage opened this issue Sep 4, 2016 · 3 comments

Comments

@maage
Copy link
Contributor

maage commented Sep 4, 2016

Selinux module can contain .te, .if adn .fc files. See https://github.com/TresysTechnology/refpolicy/tree/master/policy/modules/services

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: not dependant
  • Ruby: not dependant
  • Distribution: not dependant
  • Module version: 0.4.1

How to reproduce (e.g Puppet code you use)

Create selinux module with multiple file types and try to use selinux::module to manage it.

What behaviour did you get

So far I have not been able to manage single selinux module. Somehow te file ends up being directory.

What behaviour did you expect instead

I expect to get similar behaviour than spiette/selinux. See:
https://github.com/spiette/puppet-selinux/blob/master/manifests/module.pp

Put selinux module files into puppet module files/selinux and then enable module by:

  ::selinux::module { 'myselmodulename':
    ensure => 'present',
    source => "puppet:///modules/${module_name}/selinux",
  }
@maage
Copy link
Contributor Author

maage commented Sep 4, 2016

I have branch with fixes:
https://github.com/cybercom-finland/puppet-selinux/tree/module-source-directory-118
But I would like to have #117 fixed before.

@maage
Copy link
Contributor Author

maage commented Sep 4, 2016

Also it might be benefical to restore API from spiette module totally, but I'm not sure about what I've dropped.
https://github.com/spiette/puppet-selinux/blob/master/manifests/module.pp

@vinzent
Copy link
Contributor

vinzent commented Jan 17, 2017

In my opinion the selinux::module param should not synchronize a directory.

@maage if this is important for you please provide proposals on the issue #178 within the next few days.

@vinzent vinzent closed this as completed Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants