-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-flexbox-1] Add definitions for outer main/cross size in terminology #11425
Comments
Doesn't seem invalid to me.
"hypothetical main size" is a clearly defined term, why are you trying to replace parts of the term with a possible synonym?
I mean, not opposed, but seem unnecessary unless you are very nitpicky, and in that case these don't help either because they define "outer main size" and not "outer hypothetical main size". |
This issue specifically concerns the use of the term "outer" in phrases like:
The confusion is not with the phrase "hypothetical main/cross size", which indeed resolves correctly since "hypothetical" is about the min/max constraints applied to width/height. The problem arises when "outer" is combined with "cross size" / "hypothetical main size" / "flex base size" under the current definitions, as it creates a semantic conflict— read: "margin box size I proposed defining "outer main size" and not "outer hypothetical main size" Since I find it intuitive how "hypothetical" would apply in context when "outer main size" is clearly defined. That said, if clarity demands further precision, I would fully support including the following definitions:
|
The spec is modifying the term "size" with the adjectives "outer" "hypothetical" and "main". These are defined through the definitions of "outer size" "hypothetical size" and "main size". Standard English rules for combining adjectives apply. We could improve the linking, but like Oriol, I don't think there's a problem with the definitions here. |
Your explanation of "adjective modifying size" oversimplifies the issue. "Outer" and "hypothetical" refer to different types of size, not just modify "size" itself. Terms like "outer hypothetical main size", "outer cross size", and "outer flex base size" combine distinct concepts: "outer" relates to the margin box, while "hypothetical main size" concerns the content box after constraints. Combining these terms results in conflicting meanings, making the phrasing unclear. Clearer definitions would better capture their intended meanings in the spec. Note that the terms "hypothetical" and "main" are not defined independently. In particular, the spec states:
|
The specification frequently uses phrases like:
"outer hypothetical main size"
"outer hypothetical cross size"
"outer cross size"
"outer flex base size"
However, the current terminology defines "main size" and "cross-size" in terms of
width
orheight
.In English writing mode (row direction), this results in an invalid phrases like:
is "resolved" as:
when the intended meaning is actually:
To resolve this, I propose adding explicit definitions:
For the phrase "outer flex base size", given its limited occurrences, I recommend rephrasing it as:
The text was updated successfully, but these errors were encountered: