Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose interactionId to keypress #134

Open
zuoaoyuan opened this issue Jun 7, 2023 · 0 comments
Open

Expose interactionId to keypress #134

zuoaoyuan opened this issue Jun 7, 2023 · 0 comments
Assignees

Comments

@zuoaoyuan
Copy link
Contributor

Context:

Event timing has added interactionId attribute to all entries, but to most entry types, its value would be 0. Currently it's only exposed to [pointerdown, pointerup, click, keydown, keyup] with non-trivial values.

Issue:

Keypress is possible to have the longest duration among all the entries from the same interaction, but having an interactionId 0 makes it not being counted towards INP and makes INP not reflecting the real user experience.
image

Proposed solution:

Event timing assign valid interactionId to keypress entry, and match it with the same interactionId of the keydown & keyup entries from the same interaction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant