-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New proposal: long animation frames #103
Comments
@noamr, This is a great initiative! I would love to see something like this gets implemented and to experiement with this. Some initial thoughts:
|
It needs to also reset
I put it as a future thing in the end, wanted to start with the basics.
It's correct enough.
I'll add it as a future thing
Yes I'm aware of the JS profiler. The idea here is to have something with low overhead that you can keep running for a long time and not have to turn on/off. I see profiling vs. performance-observers as two different layers of performance measurements.
Absolutely, as long as you're ok with the overhead of JS profiling :)
Exactly, LoAF performance observers, unlike JS profilers, aim to have near zero overhead. |
@nhelfman I've updated the explainer a bit. Thanks for your comments! |
Hi Noam, Thanks for the work and I like the API! For the privacy aspect, I wonder if you could add a section to the explainer to explain what origin can access what information? I'd assume that for things like layout computation time, we don't want third party to access them? I know you've explained this in the meeting, but still want to double check with you in case I missed anything. My another concern is the performance overhead and glad that it's aiming for zero overhead. Thanks! |
Will do. For layout computation time, For frames in your own agent it's observable today if you layout-thrash or use resize observers. I'll add some wording on it here.
Aiming for negligible overhead :) not sure I can write any code with absolute zero overhead :) I think there would have to be some fine tuning of:
|
@sefeng211: Added a security & privacy blurb to the explainer PR: cd59f77 |
This is a revamp of proposals that went around before, with some changes.
Long tasks are marketed as the way to diagnose responsiveness/jank.
However, in the years since we've shipped them we found that they are lacking:
The revamp:
Counting frames instead of tasks: from the beginning of a task until one of the following:
In addition, add information about how long it took to style&layout, as well as a breakdown of long-running same-frame top-level scripts, plus additional information that can help diagnose long main-thread blocking periods.
Some of these details need to be fleshed out, we're planning to test what kind of information they produce in Chrome before going through scrutiny.
See explainer PR: #100
Addresses #89
The text was updated successfully, but these errors were encountered: