Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overloading PerformanceEntry #133

Open
Elchi3 opened this issue Jan 17, 2024 · 1 comment
Open

Overloading PerformanceEntry #133

Elchi3 opened this issue Jan 17, 2024 · 1 comment
Assignees

Comments

@Elchi3
Copy link

Elchi3 commented Jan 17, 2024

Why is this specification overloading PerformanceEntry in the IDL? E.g.:

interface PerformanceLongTaskTiming : PerformanceEntry {
/* Overloading PerformanceEntry */
    readonly attribute DOMHighResTimeStamp startTime;
    readonly attribute DOMHighResTimeStamp duration;
    readonly attribute DOMString name;
    readonly attribute DOMString entryType;
}

For documentation tooling this means that there are now distinct startTime, duration, name, entryType properties for the PerformanceLongTaskTiming, TaskAttributionTiming, PerformanceLongAnimationFrameTiming, PerformanceScriptTiming interfaces. Previously these were just documented with the PerformanceEntry interface once for all.

It seems that no other Performance spec does this. So, for our tooling it means that LargestContentfulPaint, LayoutShift, PerformanceElementTiming, PerformanceEventTiming, PerformanceMark, PerformanceMeasure, PerformancePaintTiming, etc. etc. can all refer to PerformanceEntry for these properties as they are not appearing as "overloading" in their IDLs again. That seems inconsistent with what this spec is doing as of 61a67ee. Maybe I'm missing something, though.

@noamr
Copy link
Contributor

noamr commented Feb 9, 2024

Will fix this once #132 is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants