Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor make_line in kwave.utils.mapgen #263

Open
waltsims opened this issue Jan 16, 2024 · 6 comments · May be fixed by #374
Open

Refactor make_line in kwave.utils.mapgen #263

waltsims opened this issue Jan 16, 2024 · 6 comments · May be fixed by #374
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@waltsims
Copy link
Owner

Refactor make_line. The function is too long and confusing and could be broken down into subfunctions and simplified.
@waltsims waltsims added enhancement New feature or request good first issue Good for newcomers labels Jan 16, 2024
@Harish-M-2003
Copy link

@waltsims Would you mind assigning this issue to me? I would appreciate the opportunity to work on it.

@waltsims
Copy link
Owner Author

Hey Harish,

welcome! I look forward to your PR.

Best,
Walter

@Harish-M-2003
Copy link

Hi @waltsims ,

Thank you for the warm welcome!

Best regards,
Harish

@waltsims
Copy link
Owner Author

Hey @Harish-M-2003, Checking in on this Issue. Do you think you would be able to close a PR by the deadline for the v0.3.3 milestone on April 3rd?

@Harish-M-2003
Copy link

Unfortunately, I regret to inform you that I am unable to continue with it at this time. I apologize for any inconvenience this may cause

@waltsims
Copy link
Owner Author

No problem.

@faridyagubbayli faridyagubbayli linked a pull request Apr 23, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor make_line waltsims/k-wave-python
2 participants
@waltsims @Harish-M-2003