-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should update to match the new spec #4
Comments
@zcorpan - Unless I'm mistaken, the polyfill seems correct. According to the latest working spec (Nov 13 2014):
|
Aaargh! That's the old spec. -_- We tried to kill all copies but it seems W3C is good at producing many copies scattered around so it's hard to catch all of them. Also the spec's date is a lie. You want to look at https://html.spec.whatwg.org/multipage/embedded-content.html#introduction-3 cheers |
Thanks @zcorpan and @booleanbetrayal for your comments. @zcorpan, would you say borismus/srcset-polyfill is the definitive polyfill for this functionality? If so, I'd like to put effort into fixing its issues rather than maintaining this project which may/will have its own issues. I appreciate any feedback you have to offer. |
No, I just wanted to point to my comment above instead of copy-pasting it. If you are looking to contribute to a different project that is further along, I suggest checking scottjehl/picturefill#374 |
We’d love to have the help over at Picturefill, if you’re interested! |
Thanks @Wilto, I've been watching the project for a long time. I contributed early on before version 2 but haven't since, just because it looked like there was good movement and a lot changing. I didn't want to add extra noise. |
It looks like this polyfill implements the old spec for srcset, where 'w' descriptors meant viewport max-width. The current spec makes 'w' descriptors mean width of the image, to be used together with the sizes attribute. The functionality for the old 'w' is available by using the picture element.
The text was updated successfully, but these errors were encountered: