Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better protect critical infra components like EFS against accidental deletion #12

Open
mgeerdsen opened this issue Feb 27, 2018 · 5 comments
Assignees
Labels
Milestone

Comments

@mgeerdsen
Copy link
Contributor

a different stack for protected resources was suggested together with a matching lifecycle policy

@pollecuttn
Copy link

@mgeerdsen @opaetzel Is this still to be done? Does it need to be moved to the Q3 project board? Please move it if it does.

@opaetzel opaetzel added the migration Needed for migration to AWS label Jan 29, 2019
@opaetzel opaetzel added this to the M2 milestone Jan 29, 2019
@mgeerdsen
Copy link
Contributor Author

actually critical infra in general should be better protected against deletion, including S3 buckets, EFS and the databases

  • prevent_destroy should be added where possible to those - not easily possible for at least EFS, as that is used via a module
  • deletion protection could be enabled for RDS - might not be supported in the module currently
  • repo could be sorted into critical and "non-critical" infrastructure

@pollecuttn
Copy link

@mgeerdsen Does this still need to be done? Or can the issue be closed?

@mgeerdsen mgeerdsen changed the title protect EFS from deletion during deployment better protect critical infra components like EFS against accidental deletion Jan 23, 2020
@mgeerdsen mgeerdsen modified the milestones: M2, M4 Jan 23, 2020
@mgeerdsen
Copy link
Contributor Author

This is not all that critical anymore with backups being in place, but I would like to improve on this in the future a bit as terraform code will need improvements anyway.

@mgeerdsen mgeerdsen added infra and removed migration Needed for migration to AWS labels Mar 25, 2020
@aray-wellcome
Copy link

Related to #411

@aray-wellcome aray-wellcome reopened this Mar 18, 2024
@github-project-automation github-project-automation bot moved this to Check Relevency in 2024 Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Check Relevency
Development

No branches or pull requests

4 participants