Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Woo POS] Pulling to refresh when the current items page height is shorter than view height triggers API request twice #14735

Open
1 of 3 tasks
jaclync opened this issue Dec 20, 2024 · 1 comment · May be fixed by #14833
Open
1 of 3 tasks

[Woo POS] Pulling to refresh when the current items page height is shorter than view height triggers API request twice #14735

jaclync opened this issue Dec 20, 2024 · 1 comment · May be fixed by #14833
Assignees
@jaclync
Labels
feature: POS priority: low Not many people are affected or there’s a workaround, etc. type: bug A confirmed bug.

Comments

@jaclync
Copy link
Contributor

jaclync commented Dec 20, 2024 •
edited
Loading

Describe the bug

Pulling to refresh should only one API request, but it's currently triggering 2 when the items are not filling the view height due to trigger of infinite scroll in addition to pull-to-refresh.

To Reproduce
Steps to reproduce the behavior:

  • Switch to a store eligible for POS, and only has purchasable simple/variable products < 1 page like 1-2
  • Go to Menu > Point of Sale mode
  • After the initial items are loaded, pull to refresh --> check the network requests, notice that 2 requests are triggered from the pull-to-refresh

Screenshots

Simulator.Screen.Recording.-.iPad.Pro.11-inch.M4.-.2024-12-20.at.09.29.19.mp4

Expected behavior

Only one API request should be made from any pull-to-refresh.

Isolating the problem (mark completed items with an [x]):

  • I have deactivated other plugins and confirmed this bug occurs when only WooCommerce plugin is active.
  • This bug happens with a default WordPress theme active, or Storefront.
  • I can reproduce this bug consistently using the steps above.

Mobile Environment
Please include:

  • Device: iPad Pro 11in
  • iOS version: iOS 18.0
  • WooCommerce iOS version: 21.3
@jaclync jaclync added feature: POS priority: medium Planned tasks usually belonging to ongoing projects type: bug A confirmed bug. priority: low Not many people are affected or there’s a workaround, etc. and removed priority: medium Planned tasks usually belonging to ongoing projects labels Dec 20, 2024
@dangermattic
Copy link
Collaborator

Thanks for reporting! 👍

This was referenced Dec 20, 2024
Merged
Merged
@jaclync jaclync self-assigned this Jan 8, 2025
@jaclync jaclync linked a pull request Jan 9, 2025 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaclync jaclync

Labels
feature: POS priority: low Not many people are affected or there’s a workaround, etc. type: bug A confirmed bug.
Projects
None yet
Milestone
No milestone
2 participants
@jaclync @dangermattic