Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check to ensure CHANGELOG.md can be committed #247

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

6543
Copy link
Member

@6543 6543 commented Nov 28, 2024

close #242

@6543 6543 added the enhancement Enhance existing feature label Nov 28, 2024
@6543 6543 requested a review from anbraten as a code owner November 28, 2024 16:16
@anbraten anbraten changed the title Add savety check to make sure CHANGELOG.md is able to be commited Add check to ensure CHANGELOG.md can be committed Nov 28, 2024
@anbraten
Copy link
Member

anbraten commented Dec 8, 2024

Not sure about this one. If you decided to ignore it, that should be accounted, shouldn't it?

@6543
Copy link
Member Author

6543 commented Dec 8, 2024

well or that way around :D

@6543
Copy link
Member Author

6543 commented Dec 8, 2024

well with git check-ignore CHANGELOG.md if it returns CHANGELOG.md it is ignored ... now we just have to see how simple git can do that

@6543
Copy link
Member Author

6543 commented Dec 9, 2024

Not sure about this one. If you decided to ignore it, that should be accounted, shouldn't it?

Can we create pull requests that have no diff and merge such? (on raw git via shell yes ... but forges do add restrictions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhance existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add savetycheck that generated changelog file is not excludet
2 participants