Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9.0 API Errors #11

Open
VaporAPX opened this issue Aug 21, 2020 · 11 comments
Open

9.0 API Errors #11

VaporAPX opened this issue Aug 21, 2020 · 11 comments

Comments

@VaporAPX
Copy link

With the changes to Setbackdrop, like more addons this one is throwing errors now too. It also has several errors that throw when calling the 'core' function for the various units.

Errors

@VaporAPX
Copy link
Author

The top error was fixed with updating OuF to its current beta release, but the others persist. I'm sure it's a simple fix but I'm stuck using ElvUI until then lol. Thanks in advance.

@xmyno
Copy link
Owner

xmyno commented Aug 25, 2020

Unfortunately I have not been playing the game for over a year and have no intention of returning, so there will be no further updates, sorry.

@VaporAPX
Copy link
Author

This makes me sad all day :( What can I bribe you with for one last fix for shadowlands? lol. I love this UI, been using it for years, just not smart enough to make it work.

@Spatcholla
Copy link
Contributor

I have not played in almost two years now but I am getting pulled back in; if it is okay with @xmyno I'll take a look and see if I can hack my way through it. As I am currently downloading the game it may take a bit for me to even wrap my head around the wow api again. @xmyno are you good with me working on this?

@Spatcholla
Copy link
Contributor

After playing around for a little bit and fixing the issue, I noticed @ddez180001 had already put in a PR that fixes this and then some.

@VaporAPX
Copy link
Author

VaporAPX commented Sep 1, 2020

This layout was working fine in 8.3. @xmyno updated it when 8.3 was still in beta testing (with some relay work from myself). These new errors are from the ptr/shadowlands beta and the 9.0 api.

@VaporAPX
Copy link
Author

I manually went through last night and added all the SetBackdrop mixin fixes to every frame and got the majority of the addon to work. The only parts that still error are the mirror bar and desaturating non player debuffs on target frame. I don't know if the way I did it is the best way though. So an actual fix to this issue would be great @Spatcholla. I'm sure you have much better LUA knowledge than I do :)

@Aideenwolf
Copy link

Aideenwolf commented Oct 16, 2020

I posted this on WOWI too -
https://drive.google.com/file/d/1ZqLTyJ0p9ih_R2jQjnCi_C5RKCWiuMAQ/view?usp=sharing

So I was able to get it working There were quite a few changes. and I don't really understand how to use GITHUB..

You do have to have the latest version of OUF (10.0.1 at the time of my testing)
I also changed the ver to 9.0 (in line with the SL patch) and updated the TOC

@xmyno
Copy link
Owner

xmyno commented Oct 17, 2020

@Aideenwolf Thank you very much. I started going through your changes and added them on the develop branch with some additional fixes. Looking good so far on initial testing.

I can't really test it in actual combat or group play so I have to rely on feedback from you all :)

@Aideenwolf
Copy link

Aideenwolf commented Oct 18, 2020

@xmyno I threw in one more fix (that I found last night) Like I said.. I'm not too knowledgeable about github so I hope it shows up.

if it didn't
core.lua
Line 258 (for me)

		-- Desaturate non-Player Debuffs
		if icon.filter == "HARMFUL" then
			if (unitCaster == 'player' or unitCaster == 'vehicle') then
				icon.icon:SetDesaturated(nil)
			elseif(not UnitPlayerControlled(unit)) then -- If Unit is Player Controlled don't desaturate debuffs
				Mixin(icon, BackdropTemplateMixin or {}) -- Test to prevent debuff errors in raids
				icon:SetBackdropColor(0, 0, 0)
				icon.icon:SetDesaturated(1)
			end
		end
	end

@xmyno
Copy link
Owner

xmyno commented Oct 18, 2020

@Aideenwolf Added (389430b), thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants