Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify some menu labels - enhancement #45

Open
bendover22 opened this issue Oct 21, 2018 · 10 comments
Open

Modify some menu labels - enhancement #45

bendover22 opened this issue Oct 21, 2018 · 10 comments

Comments

@bendover22
Copy link

Just some suggestions.
Wouldn't "Cookie Quick Manager" option be better described as something like "Manage All Cookies"? We already know it's CQM - describe what (any) option actually does.

"Delete Current Cookies" might be better described as "Delete Current Site (or Domain) Cookies"
"Delete Current Site Local Storage" instead of "Delete Current Local Storage" (see below).

In English, "delete current..." generally means all data currently in (local storage, or what ever), which would include all sites that had stored anything, unless stated otherwise. But it actually means the current selected tab.

The toolbar CQM icon doesn't look like a cookie - even on a large, Hi Def monitor.
Maybe someone could find an non copy righted one.
At a normal viewing distance, to me it doesn't look like anything. I've used it a while & it still doesn't register what it is, though the icon isn't the most pressing issue.

@ysard
Copy link
Owner

ysard commented Oct 22, 2018

Thank you for your clarification about my English translation, I will include it as soon as possible.

I will also try to rework the icon; feel free to offer a source of inspiration.

@ysard
Copy link
Owner

ysard commented Nov 12, 2018

I close this issue but I keep in mind the need to rework the cookie icon one day.
Feel free to open another one for any translation problem :)

@ysard ysard closed this as completed Nov 12, 2018
@practik
Copy link

practik commented Nov 15, 2018

Just to give you one other data point, @ysard, the icon looks fine to me; I never gave it a second thought.

@ysard
Copy link
Owner

ysard commented Nov 15, 2018

Understood, maybe people are eating cookies with a different look in different countries: D

@bendover22
Copy link
Author

bendover22 commented Nov 18, 2018 via email

@bendover22
Copy link
Author

bendover22 commented Dec 2, 2018

ysard,
Did you see the modified icon that I attempted to upload, or did you just not like it?
I did it quickly - didn't know if you'd like it - a cookie with M & M's candy on top (a favorite of many kids). Much more colorful & visible @ 16x16px. Like https://www.pinterest.com/pin/796855727791888298/

When icons are reduced to 16x16 px, muted colors or small details become almost invisible.
I measured some other addon nav bar icons & overall, they're a good bit bigger than 16 x 16, when they add some sort of counter, so there's no reason (I'm aware of) the CQM icon couldn't be a bit bigger than 16x16. Or maybe there is a reason, if there's no counter on it.

I could make it a whole round cookie in the same M & M's design or other, as lots of cookie-related addons use a cookie with a missing bite. CQM's cookie could be fresh & whole, not half eaten. :) Addons need something that's recognizable & unique.

You could use the modern design for yin & yang (1st is 48x48; 2nd is 16x16)
image

image

We could do one in black / white or any color designs, like wavy lines of icing across the top. Sort of like https://www.shutterstock.com/image-photo/cup-coffee-chocolate-chip-cookies-on-75508834?src=5zj066G7-gPZY5yQ5yx5_w-1-100

These pages have lots of ideas.
https://www.shutterstock.com/search/black+and+white+cookie

There's also a famous, real style / recipe of "Black & White Cookies." Half black, half white icing.
https://www.amazon.com/Beigels-Black-White-Cookies-Tray/dp/B00N9QQ6RI

@ysard
Copy link
Owner

ysard commented Dec 6, 2018

Hello, please excuse me for the lack of responsiveness, I take care of many projects and it is difficult to allocate the best time on each of them...

Unfortunately, I did not receive your attachment by email.

First of all the icons requested by Mozilla must be in the format 48x48 and 96x96 for the visible icon on the site and in the list of add-ons in Firefox itself.

Elsewhere, in the software or on the interface of Firefox they are effectively resized at 16x16.

Usually I work in SVG and I get from this format the different assets I need.

I don't plan to display a counter above the addon in the immediate future.

I think it's important to see what the different ideas look like on the interface. I was more sensitive to a cookie with coloured sugar cubes. The main thing is not to advertise for Oreo :p

@ysard ysard reopened this Dec 6, 2018
@bendover22
Copy link
Author

bendover22 commented Dec 7, 2018 via email

@bendover22
Copy link
Author

Here are some much improved CQM icons / images. I added the latest revised image to the Fx nav bar (downsized to 16px) & it looks better to me; much easier to notice & has more color.

You said you usually worked w/ SVG, but Github says: doesn't support uploading .SVG files.
So I'll have to use .PNG for this post. I have them in SVG, if you want me to send by email or load to some image sharing site. They're only 7 KB & 21 KB.

  • Made the "bite" from the cookie much smaller, so more icon is visible, noticeable.
  • Made the round, colored candy pieces a bit larger & more round (using feathering).
  • Made the candies' colors brighter, more intense. Not every user has perfect eyesight to see small images w/ muted colors.
  • Added a slightly wider, darker border on the entire circumference, that shows better on a medium to light background.

A dark border won't show up on a dark theme, but if the border is light, it won't show on light themes. That would only be solved by including 2 sets of icons & users had some option to choose the suitable colors. Very few addons do that.

Perhaps making the entire background of the cookie lighter (with or w/o a border) & the bright colored "M&M's". If you have a preference for the border, let me know.

cookie quick mgr-new color icon-48-r1

cookie quick mgr-new color icon-96-r1

@shodanx2
Copy link

Hello,

I would like to recomment the following UI changes

Left click should directly open the cookie-quick-manager tab

The option in the current left-click content menu, should be added to the right click context menu

Here is an example of doing so from the add-on copy-tabs

image

These options used also be on a left-click context menu, which made using the add-on a 3 step process (click-decision-click) greatly increasing the cognitive burden of using the add-on

By moving these options to the right click context menu, they no longer are an obstacle to using the add-on's main features while the right click context menu now contains shortcuts for advanced users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants