Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hyphens instead of underscores for property separation #83741

Open
6 of 18 tasks
rruuaanng opened this issue Jan 9, 2025 · 4 comments
Open
6 of 18 tasks

Use hyphens instead of underscores for property separation #83741

rruuaanng opened this issue Jan 9, 2025 · 4 comments
Labels
area: Devicetree Binding PR modifies or adds a Device Tree binding Enhancement Changes/Updates/Additions to existing features Meta A collection of features, enhancements or bugs

Comments

@rruuaanng
Copy link
Collaborator

rruuaanng commented Jan 9, 2025

Is your enhancement proposal related to a problem? Please describe.

#53506 #83352 work list

In the current source tree, all properties in devicetree and bindings across subsystems that contain underscores need to be renamed using hyphens.
(The scope of work only includes the dts/ directory. However, if any DTS files located in other directories depend on the bindings, please disregard this statement and feel free to make changes as needed.)

dts/bindings/

Describe the solution you'd like

None

Describe alternatives you've considered

None

Additional context

A change probably includes such a process:

  1. e.g. This property tick_us needs to be renamed to tick-us.
  2. Modify the corresponding property name in the corresponding binding.

These two are exceptions:

mmc-hs400-1_8v
mmc-hs200-1_8v

And, you can get a migration script from 9fcf476 to quickly change the binding name.

@rruuaanng rruuaanng added the Enhancement Changes/Updates/Additions to existing features label Jan 9, 2025
@rruuaanng
Copy link
Collaborator Author

If you're interested, feel free to take on any of these tasks. I truly appreciate all your efforts!

@henrikbrixandersen henrikbrixandersen added area: Devicetree Binding PR modifies or adds a Device Tree binding Meta A collection of features, enhancements or bugs labels Jan 10, 2025
@henrikbrixandersen
Copy link
Member

henrikbrixandersen commented Jan 10, 2025

@rruuaanng Thank you for opening this.

For the CAN bindings the only underscores, I see, are:

@rruuaanng
Copy link
Collaborator Author

Thank you for the time you spent on this task, Henrik, it was quite difficult to locate them 👍

@rruuaanng
Copy link
Collaborator Author

cc @jilaypandya Maybe you will be interested in stepper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Devicetree Binding PR modifies or adds a Device Tree binding Enhancement Changes/Updates/Additions to existing features Meta A collection of features, enhancements or bugs
Projects
None yet
Development

No branches or pull requests

2 participants