Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

artifactv2 is deprecated so workflows don't run #165

Open
sphaero opened this issue Dec 4, 2024 · 4 comments
Open

artifactv2 is deprecated so workflows don't run #165

sphaero opened this issue Dec 4, 2024 · 4 comments

Comments

@sphaero
Copy link
Contributor

sphaero commented Dec 4, 2024

https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

@sphaero sphaero changed the title artifactv2 is deprecated so workflows don artifactv2 is deprecated so workflows don't run Dec 4, 2024
@philrhc
Copy link

philrhc commented Dec 9, 2024

i'll take a look at this to get #164 merged

@sphaero
Copy link
Contributor Author

sphaero commented Dec 10, 2024

Almost there:

Push to branch refs/heads/master
/home/runner/work/_actions/ad-m/github-push-action/master/start.sh: line 18: Missing input 'github_token: ${{ secrets.GITHUB_TOKEN }}'.: bad substitution
Error: Invalid exit code: 1
    at ChildProcess.<anonymous> (/home/runner/work/_actions/ad-m/github-push-action/master/start.js:30:21)
    at ChildProcess.emit (node:events:519:28)
    at maybeClose (node:internal/child_process:1105:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5) {
  code: 1
}

@philrhc
Copy link

philrhc commented Jan 7, 2025

Almost there:

Push to branch refs/heads/master
/home/runner/work/_actions/ad-m/github-push-action/master/start.sh: line 18: Missing input 'github_token: ${{ secrets.GITHUB_TOKEN }}'.: bad substitution
Error: Invalid exit code: 1
    at ChildProcess.<anonymous> (/home/runner/work/_actions/ad-m/github-push-action/master/start.js:30:21)
    at ChildProcess.emit (node:events:519:28)
    at maybeClose (node:internal/child_process:1105:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5) {
  code: 1
}

hello, happy new year,
i've fixed this here: #168
i will revisit my implementation of set_interface to get that ready for your review.
thanks!

@philrhc
Copy link

philrhc commented Jan 8, 2025

this can be closed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants