You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR refactor(metal_mont_backend): adapted from https://github.com/geometryxyz/msl-secp256k1 #13 introduced a comprehensive refactoring and enhancement of the Metal MSM module, including an EC backend adapted from Tal and Koh's work on Zprize 2023, various arithmetic operations, benchmarking, and testing suites. The original PR is quite large and spans multiple distinct domains. To maintain clarity, improve review efficiency, and track incremental progress, we need to split the original PR into several smaller PRs.
Goals
Sub PRs:
BigInt Operations: BigInt arithmetic functionalities (addition, subtraction for arbitrary limb size and tests).
Field Operations: Field arithmetic functionalities (addition, subtraction above field).
Elliptic Curve Operations: ECPoint types definition and associated point addition/doubling operations.
Close the Original PR:
Once the new PRs are created and reference this issue, the original PR will be closed in favor of the smaller, more manageable contributions.
Acceptance Criteria:
Each new PR should be self-contained and properly documented.
All new PRs should reference this issue to maintain proper traceability.
The original PR should be closed only after these new PRs are created and are in review.
The EC algorithms for point addition (pADD), point mixed addition (pMADD), and point doubling (pDBL) successfully passed the correctness test using random inputs.
Description
Goals
Sub PRs:
BigInt Operations:
BigInt
arithmetic functionalities (addition, subtraction for arbitrary limb size and tests).Field Operations:
Field
arithmetic functionalities (addition, subtraction above field).Montgomery Multiplication
link to Implement Optimized Montgomery Multiplication for Metal #6
Elliptic Curve Operations:
ECPoint
types definition and associated point addition/doubling operations.Close the Original PR:
Once the new PRs are created and reference this issue, the original PR will be closed in favor of the smaller, more manageable contributions.
Acceptance Criteria:
References:
The text was updated successfully, but these errors were encountered: